From: He Chen <he.chen@linux.intel.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
Andrew Jones <drjones@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v9] Allow setting NUMA distance for different NUMA nodes
Date: Fri, 28 Apr 2017 17:39:11 +0800 [thread overview]
Message-ID: <20170428093911.GA26067@he> (raw)
In-Reply-To: <20170427202551.GL3482@thinpad.lan.raisama.net>
On Thu, Apr 27, 2017 at 05:25:51PM -0300, Eduardo Habkost wrote:
> On Thu, Apr 27, 2017 at 04:46:26PM +0200, Igor Mammedov wrote:
> > On Thu, 27 Apr 2017 16:05:42 +0200
> > Markus Armbruster <armbru@redhat.com> wrote:
> > > Igor Mammedov <imammedo@redhat.com> writes:
> > > > On Thu, 27 Apr 2017 07:54:31 -0500
> > > > Eric Blake <eblake@redhat.com> wrote:
> [...]
> > > >>
> > > >> Markus has asked that all new QMP commands have some testsuite exposure;
> > > >> he may have some advice on what test would be best to modify to give us
> > > >> some coverage of this feature.
> > >
> > > I can't see the QMP command here, but...
> > >
> > > > Since it's basically validation of SLIT table, the test case
> > > > should be added to tests/bios-tables-test.c
> > >
> > > ... I figure there's new stuff to test all the same.
> > it could be a patch on top and doesn't have to hold this one if
> > author promises to write testcase
>
> Agreed. I'm applying this to my machine-next branch, but I would
> like to get test cases before including it in a pull request.
>
You mean we also need a patch to add test case to
tests/bios-tables-test.c, right? If so, I am very willing to cook and
submit it.
next prev parent reply other threads:[~2017-04-28 9:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 2:35 [Qemu-devel] [PATCH v9] Allow setting NUMA distance for different NUMA nodes He Chen
2017-04-27 9:21 ` Igor Mammedov
2017-04-27 9:27 ` Andrew Jones
2017-04-27 9:33 ` Daniel P. Berrange
2017-04-27 12:54 ` Eric Blake
2017-04-27 13:32 ` Igor Mammedov
2017-04-27 14:05 ` Markus Armbruster
2017-04-27 14:46 ` Igor Mammedov
2017-04-27 20:25 ` Eduardo Habkost
2017-04-28 9:39 ` He Chen [this message]
2017-04-28 9:55 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170428093911.GA26067@he \
--to=he.chen@linux.intel.com \
--cc=armbru@redhat.com \
--cc=drjones@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).