From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33286) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d46DM-00053p-E6 for qemu-devel@nongnu.org; Fri, 28 Apr 2017 09:45:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d46DL-0005p8-LK for qemu-devel@nongnu.org; Fri, 28 Apr 2017 09:45:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46810) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d46DL-0005ov-Ek for qemu-devel@nongnu.org; Fri, 28 Apr 2017 09:45:39 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 65D08C05490B for ; Fri, 28 Apr 2017 13:45:37 +0000 (UTC) Date: Fri, 28 Apr 2017 14:45:32 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170428134532.GG2085@work-vm> References: <20170427165526.19836-1-dgilbert@redhat.com> <20170428134230.GB11415@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170428134230.GB11415@redhat.com> Subject: Re: [Qemu-devel] [PATCH] checkpatch: Disallow glib asserts in main code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, armbru@redhat.com * Daniel P. Berrange (berrange@redhat.com) wrote: > On Thu, Apr 27, 2017 at 05:55:26PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Glib commit a6a875068779 (from 2013) made many of the glib assert > > macros non-fatal if a flag is set. > > This causes two problems: > > a) Compilers moan that your code is unsafe even though you've > > put an assert in before the point of use. > > b) Someone evil could, in a library, call > > g_test_set_nonfatal_assertions() and cause our assertions in > > important places not to fail and potentially allow memory overruns. > > > > Ban most of the glib assertion functions (basically everything except > > g_assert and g_assert_not_reached) except in tests/ > > > > This makes checkpatch gives an error such as: > > > > ERROR: Use g_assert or g_assert_not_reached > > #77: FILE: vl.c:4725: > > + g_assert_cmpstr("Chocolate", >, "Cheese"); > > Or could we perhaps instead undo the damage via a hack like > > #define g_assert_cmpint g_assert_cmpint_orig > #define g_assert_cmpint(x, y, z) \ > g_assert_cmpint_orig(x, y,x); \ > abort() I'd be kind of OK adding a q_assert_cmpint if you wanted, but I think we shouldn't change the semantics of a public name. Dave > > Regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK