Re: [Qemu-devel] [PATCH] (RFC) remove the GThread coroutine implementation

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1068 bytes --]

On Sun, Apr 30, 2017 at 07:20:54AM +0100, Alex Bennée wrote:
> 
> Richard Henderson <rth@twiddle.net> writes:
> 
> > On 04/28/2017 02:24 PM, Daniel P. Berrange wrote:
> >> At the 2016 summit it was suggested that we delete the GThread
> >> coroutine impl since it is not fully functional, and you can
> >> debug the ucontext impl with our GDB helper script.
> >>
> >> I don't recall the subject being raised again since the summit
> >> so here's a proposal to delete the GThread impl, as a way to
> >> trigger input from anyone who thinks we need to keep it......
> >
> > The last time this was mentioned, the reason that we were keeping it
> > was to make clang's thread-sanitizer module happy.  Whether we can
> > still find relevant bugs with that, I don't know.
> 
> It's been a while since I last did a ThreadSanitizer run. The correct
> fix is teaching the sanitizer about set context so we can use our normal
> build - however this has been at the bottom of a pile for such a long
> time.

Any objections to merging this patch?

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]