From: "Daniel P. Berrange" <berrange@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 5/5] Revert "qemu-img: copy *key-secret opts when opening newly created files"
Date: Tue, 2 May 2017 15:32:09 +0100 [thread overview]
Message-ID: <20170502143209.GD16624@redhat.com> (raw)
In-Reply-To: <31bf6b6d-27c4-6519-e3f8-23a537e8f707@redhat.com>
On Tue, May 02, 2017 at 09:29:24AM -0500, Eric Blake wrote:
> On 05/02/2017 09:18 AM, Daniel P. Berrange wrote:
> > This reverts commit 37d7772f6b81613620a333862dc67e34b2fda1a9.
> > ---
> > qemu-img.c | 41 ++++++-----------------------------------
> > 1 file changed, 6 insertions(+), 35 deletions(-)
>
> Is this intentional, given that 4/5 just installed it?
Urgh, absolutely not. I thought I had killed that commit left over from
testing before I sent it, but I guess not :-(
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2017-05-02 14:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 14:18 [Qemu-devel] [PATCH v6 0/5] Improve convert and dd commands Daniel P. Berrange
2017-05-02 14:18 ` [Qemu-devel] [PATCH v6 1/5] qemu-img: add support for --object with 'dd' command Daniel P. Berrange
2017-05-02 14:18 ` [Qemu-devel] [PATCH v6 2/5] qemu-img: fix --image-opts usage with dd command Daniel P. Berrange
2017-05-02 14:18 ` [Qemu-devel] [PATCH v6 3/5] qemu-img: introduce --target-image-opts for 'convert' command Daniel P. Berrange
2017-05-02 14:18 ` [Qemu-devel] [PATCH v6 4/5] qemu-img: copy *key-secret opts when opening newly created files Daniel P. Berrange
2017-05-02 14:18 ` [Qemu-devel] [PATCH v6 5/5] Revert "qemu-img: copy *key-secret opts when opening newly created files" Daniel P. Berrange
2017-05-02 14:29 ` Eric Blake
2017-05-02 14:32 ` Daniel P. Berrange [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170502143209.GD16624@redhat.com \
--to=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).