From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, famz@redhat.com,
Max Reitz <mreitz@redhat.com>,
eblake@redhat.com
Subject: [Qemu-devel] [PATCH v17 19/23] osdep: Add qemu_lock_fd and qemu_unlock_fd
Date: Wed, 3 May 2017 00:35:54 +0800 [thread overview]
Message-ID: <20170502163558.7611-20-famz@redhat.com> (raw)
In-Reply-To: <20170502163558.7611-1-famz@redhat.com>
They are wrappers of POSIX fcntl "file private locking", with a
convenient "try lock" wrapper implemented with F_OFD_GETLK.
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
include/qemu/osdep.h | 3 +++
util/osdep.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 51 insertions(+)
diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h
index 122ff06..1c9f5e2 100644
--- a/include/qemu/osdep.h
+++ b/include/qemu/osdep.h
@@ -341,6 +341,9 @@ int qemu_close(int fd);
#ifndef _WIN32
int qemu_dup(int fd);
#endif
+int qemu_lock_fd(int fd, int64_t start, int64_t len, bool exclusive);
+int qemu_unlock_fd(int fd, int64_t start, int64_t len);
+int qemu_lock_fd_test(int fd, int64_t start, int64_t len, bool exclusive);
#if defined(__HAIKU__) && defined(__i386__)
#define FMT_pid "%ld"
diff --git a/util/osdep.c b/util/osdep.c
index 06fb1cf..3de4a18 100644
--- a/util/osdep.c
+++ b/util/osdep.c
@@ -140,6 +140,54 @@ static int qemu_parse_fdset(const char *param)
{
return qemu_parse_fd(param);
}
+
+static int qemu_lock_fcntl(int fd, int64_t start, int64_t len, int fl_type)
+{
+#ifdef F_OFD_SETLK
+ int ret;
+ struct flock fl = {
+ .l_whence = SEEK_SET,
+ .l_start = start,
+ .l_len = len,
+ .l_type = fl_type,
+ };
+ ret = fcntl(fd, F_OFD_SETLK, &fl);
+ return ret == -1 ? -errno : 0;
+#else
+ return -ENOTSUP;
+#endif
+}
+
+int qemu_lock_fd(int fd, int64_t start, int64_t len, bool exclusive)
+{
+ return qemu_lock_fcntl(fd, start, len, exclusive ? F_WRLCK : F_RDLCK);
+}
+
+int qemu_unlock_fd(int fd, int64_t start, int64_t len)
+{
+ return qemu_lock_fcntl(fd, start, len, F_UNLCK);
+}
+
+int qemu_lock_fd_test(int fd, int64_t start, int64_t len, bool exclusive)
+{
+#ifdef F_OFD_SETLK
+ int ret;
+ struct flock fl = {
+ .l_whence = SEEK_SET,
+ .l_start = start,
+ .l_len = len,
+ .l_type = exclusive ? F_WRLCK : F_RDLCK,
+ };
+ ret = fcntl(fd, F_OFD_GETLK, &fl);
+ if (ret == -1) {
+ return -errno;
+ } else {
+ return fl.l_type == F_UNLCK ? 0 : -EAGAIN;
+ }
+#else
+ return -ENOTSUP;
+#endif
+}
#endif
/*
--
2.9.3
next prev parent reply other threads:[~2017-05-02 16:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 16:35 [Qemu-devel] [PATCH v17 00/23] block: Image locking series Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 01/23] block: Make bdrv_perm_names public Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 02/23] block: Add, parse and store "force-share" option Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 03/23] block: Respect "force-share" in perm propagating Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 04/23] qemu-img: Add --force-share option to subcommands Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 05/23] qemu-img: Update documentation for -U Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 06/23] qemu-io: Add --force-share option Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 07/23] iotests: 030: Prepare for image locking Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 08/23] iotests: 046: " Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 09/23] iotests: 055: Don't attach the target image already for drive-backup Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 10/23] iotests: 085: Avoid image locking conflict Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 11/23] iotests: 087: Don't attach test image twice Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 12/23] iotests: 091: Quit QEMU before checking image Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 13/23] iotests: 172: Use separate images for multiple devices Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 14/23] tests: Use null-co:// instead of /dev/null as the dummy image Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 15/23] file-posix: Add 'locking' option Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 16/23] file-win32: Error out if locking=on Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 17/23] tests: Disable image lock in test-replication Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 18/23] block: Reuse bs as backing hd for drive-backup sync=none Fam Zheng
2017-05-02 16:44 ` Fam Zheng
2017-05-02 16:35 ` Fam Zheng [this message]
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 20/23] osdep: Fall back to posix lock when OFD lock is unavailable Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 21/23] file-posix: Add image locking to perm operations Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 22/23] qemu-iotests: Add test case 153 for image locking Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 23/23] tests: Add POSIX image locking test case 182 Fam Zheng
2017-05-11 10:08 ` Kevin Wolf
2017-05-11 11:30 ` Fam Zheng
2017-05-04 13:09 ` [Qemu-devel] [PATCH v17 00/23] block: Image locking series Kevin Wolf
2017-05-04 14:30 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170502163558.7611-20-famz@redhat.com \
--to=famz@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).