From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,
eblake@redhat.com, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v17 18/23] block: Reuse bs as backing hd for drive-backup sync=none
Date: Wed, 3 May 2017 00:44:35 +0800 [thread overview]
Message-ID: <20170502164435.GA8307@lemon.lan> (raw)
In-Reply-To: <20170502163558.7611-19-famz@redhat.com>
On Wed, 05/03 00:35, Fam Zheng wrote:
> Opening the backing image for the second time is bad, especially here
> when it is also in use as the active image as the source. The
> drive-backup job itself doesn't read from target->backing for COW,
> instead it gets data from the write notifier, so it's not a big problem.
> However, exporting the target to NBD etc. won't work, because of the
> likely stale metadata cache.
>
> Use BDRV_O_NO_BACKING in this case and manually set up the backing
> BdrvChild.
>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Fam Zheng <famz@redhat.com>
Actually Cc qemu-stable. (git-publish does unified Cc for each patch in a whole
series, hence the noise. Sorry.)
Fam
next prev parent reply other threads:[~2017-05-02 16:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 16:35 [Qemu-devel] [PATCH v17 00/23] block: Image locking series Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 01/23] block: Make bdrv_perm_names public Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 02/23] block: Add, parse and store "force-share" option Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 03/23] block: Respect "force-share" in perm propagating Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 04/23] qemu-img: Add --force-share option to subcommands Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 05/23] qemu-img: Update documentation for -U Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 06/23] qemu-io: Add --force-share option Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 07/23] iotests: 030: Prepare for image locking Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 08/23] iotests: 046: " Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 09/23] iotests: 055: Don't attach the target image already for drive-backup Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 10/23] iotests: 085: Avoid image locking conflict Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 11/23] iotests: 087: Don't attach test image twice Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 12/23] iotests: 091: Quit QEMU before checking image Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 13/23] iotests: 172: Use separate images for multiple devices Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 14/23] tests: Use null-co:// instead of /dev/null as the dummy image Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 15/23] file-posix: Add 'locking' option Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 16/23] file-win32: Error out if locking=on Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 17/23] tests: Disable image lock in test-replication Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 18/23] block: Reuse bs as backing hd for drive-backup sync=none Fam Zheng
2017-05-02 16:44 ` Fam Zheng [this message]
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 19/23] osdep: Add qemu_lock_fd and qemu_unlock_fd Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 20/23] osdep: Fall back to posix lock when OFD lock is unavailable Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 21/23] file-posix: Add image locking to perm operations Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 22/23] qemu-iotests: Add test case 153 for image locking Fam Zheng
2017-05-02 16:35 ` [Qemu-devel] [PATCH v17 23/23] tests: Add POSIX image locking test case 182 Fam Zheng
2017-05-11 10:08 ` Kevin Wolf
2017-05-11 11:30 ` Fam Zheng
2017-05-04 13:09 ` [Qemu-devel] [PATCH v17 00/23] block: Image locking series Kevin Wolf
2017-05-04 14:30 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170502164435.GA8307@lemon.lan \
--to=famz@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).