Re: [Qemu-devel] Subject: [PATCH] target-ppc: Add global timer group A to open-pic.

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]

On Tue, May 02, 2017 at 08:37:09PM -0500, alarson@ddci.com wrote:
> David Gibson <david@gibson.dropbear.id.au> wrote on 04/25/2017 11:34:41 
> PM:
> 
> Thanks for the review David.  I'll send an updated patch soon with all
> your comments addressed and all other s/0/NULL or false/ as
> appropriate and a better commit message.
> 
> Just to clarify my concern; the patch causes the QEMU openpic timer to
> be hard coded at 100MHZ.  This is common, but the openpic spec has
> numerous ways the clock could be driven and the actual frequency
> depends on target board configuration.  Given that no other users are
> apparently using the QEMU openpic timer, it is probably ok, but I did
> want to point out the deficiency.

Ah, ok.  The usual way to handle this is to have the frequency as a
property on the device.  The board code which constructs the openPIC
value can then set it to the appropriate value.

Having an interim step where its hardcoded to 100 MHz is perfectly ok
though.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]