qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, armbru@redhat.com, peterx@redhat.com
Subject: Re: [Qemu-devel] [PATCH] dump: Acquire BQL around vm_start() in dump thread
Date: Wed, 3 May 2017 15:42:40 +0800	[thread overview]
Message-ID: <20170503074240.GC9318@lemon.lan> (raw)
In-Reply-To: <20170503072819.14462-1-famz@redhat.com>

On Wed, 05/03 15:28, Fam Zheng wrote:
> This fixes an assertion failure in the following backtrace:
> 
>     __GI___assert_fail
>     memory_region_transaction_commit
>     memory_region_add_eventfd
>     virtio_pci_ioeventfd_assign
>     virtio_bus_set_host_notifier
>     virtio_blk_data_plane_start
>     virtio_bus_start_ioeventfd
>     virtio_vmstate_change
>     vm_state_notify
>     vm_prepare_start
>     vm_start
>     dump_cleanup
>     dump_process
>     dump_thread
>     start_thread
>     clone
> 
> vm_start need BQL, acquire it if doing cleaning up from main thread.

Oops, s/need/needs and s/main thread/detached thread/.

Fam

  reply	other threads:[~2017-05-03  7:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03  7:28 [Qemu-devel] [PATCH] dump: Acquire BQL around vm_start() in dump thread Fam Zheng
2017-05-03  7:42 ` Fam Zheng [this message]
2017-05-03  8:37   ` Marc-André Lureau
2017-05-04 12:58     ` Paolo Bonzini
2017-05-04 12:59 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170503074240.GC9318@lemon.lan \
    --to=famz@redhat.com \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).