From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5yRN-0006G1-6O for qemu-devel@nongnu.org; Wed, 03 May 2017 13:51:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5yRK-00075N-3V for qemu-devel@nongnu.org; Wed, 03 May 2017 13:51:53 -0400 Received: from smtp.citrix.com ([66.165.176.89]:17603) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1d5yRJ-00074n-Rb for qemu-devel@nongnu.org; Wed, 03 May 2017 13:51:50 -0400 Date: Wed, 3 May 2017 18:51:40 +0100 From: Anthony PERARD Message-ID: <20170503175140.GD1553@perard.uk.xensource.com> References: <03cfd81856554ecd91c0c317353e819b@AMSPEX02CL03.citrite.net> <51ac3ff38f464abfb98928e6fb959bf7@AMSPEX02CL03.citrite.net> <6738c7d96a1c476187f69616f25b28d1@AMSPEX02CL03.citrite.net> <20170503164838.GB1553@perard.uk.xensource.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] QEMU build breakage on ARM against Xen 4.9 caused by libxendevicemodel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: Paul Durrant , "qemu-devel@nongnu.org" , Wei Liu , "xen-devel@lists.xenproject.org" On Wed, May 03, 2017 at 10:20:59AM -0700, Stefano Stabellini wrote: > On Wed, 3 May 2017, Anthony PERARD wrote: > > On Thu, Apr 20, 2017 at 11:05:33AM -0700, Stefano Stabellini wrote: > > > On Thu, 20 Apr 2017, Paul Durrant wrote: > > > > I think xencall should be part of the base xen_stable_libs anyway. > > > > > > Yes, you are right. However I noticed that -lxencall needs to come after > > > -lxendevicemodel. So, I'll have to move -lxendevicemodel before > > > $xen_stable_libs, see below. I'll merge this patch into "configure: > > > detect presence of libxendevicemodel", if that's OK. > > > > > > diff --git a/configure b/configure > > > index 99d6cbc..3133ef8 100755 > > > --- a/configure > > > +++ b/configure > > > @@ -1992,7 +1992,7 @@ if test "$xen" != "no" ; then > > > else > > > > > > xen_libs="-lxenstore -lxenctrl -lxenguest" > > > - xen_stable_libs="-lxenforeignmemory -lxengnttab -lxenevtchn" > > > + xen_stable_libs="-lxencall -lxenforeignmemory -lxengnttab -lxenevtchn" > > > > > > # First we test whether Xen headers and libraries are available. > > > # If no, we are done and there is no Xen support. > > > @@ -2027,9 +2027,9 @@ int main(void) { > > > return 0; > > > } > > > EOF > > > - compile_prog "" "$xen_libs $xen_stable_libs -lxendevicemodel" > > > + compile_prog "" "$xen_libs -lxendevicemodel $xen_stable_libs" > > > then > > > - xen_stable_libs="$xen_stable_libs -lxendevicemodel" > > > + xen_stable_libs="-lxendevicemodel $xen_stable_libs" > > > xen_ctrl_version=40900 > > > xen=yes > > > elif > > > > Hey, now that this patch is merged, xen.git fail to build QEMU. (osstest > > qemu-mainline branch fail.) > > > > That's because -lxencall is not found because -L$path_to_libxencall is > > missing in xen.git. > > > > But I've notice something else, libxendevicemodel.so is not linked > > against libxencall, that might be the root of the issues on arm. > > (libxenctrl.so is linked against libxencall.) > > > > Thought? > > > > > > We probably need this patch in xen: > > We also need to add -L$path_to_libxencall and -I$path_to_libxencall to > tools/Makefile:subdir-all-qemu-xen-dir. I don't think that needed because: for -I, QEMU does not use anything from xencall, and any other includes does not use xencall.h. for -L, I think that would be usefull only if QEMU is built staticly. Also, I don't think -lxencall is needed at all, if libxendevicemodel is fixed. libxencall will only be a runtime dependency. > > diff --git a/tools/libs/devicemodel/Makefile b/tools/libs/devicemodel/Makefile > > index 55626a5049..81fa5a4ac4 100644 > > --- a/tools/libs/devicemodel/Makefile > > +++ b/tools/libs/devicemodel/Makefile > > @@ -63,7 +63,7 @@ libxendevicemodel.so.$(MAJOR): libxendevicemodel.so.$(MAJOR).$(MINOR) > > $(SYMLINK_SHLIB) $< $@ > > > > libxendevicemodel.so.$(MAJOR).$(MINOR): $(PIC_OBJS) libxendevicemodel.map > > - $(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxendevicemodel.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDLIBS_libxentoollog) $(APPEND_LDFLAGS) > > + $(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxendevicemodel.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxencall) $(APPEND_LDFLAGS) > > > > .PHONY: install > > install: build > > > > -- > > Anthony PERARD > > -- Anthony PERARD