From: Greg Kurz <groug@kaod.org>
To: Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>
Cc: Pradeep Jagadeesh <pradeepkiruvale@gmail.com>,
eric blake <eblake@redhat.com>, alberto garcia <berto@igalia.com>,
jani kokkonen <jani.kokkonen@huawei.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 1/4] Throttle: Create IOThrottle structure
Date: Wed, 3 May 2017 19:10:23 +0200 [thread overview]
Message-ID: <20170503191023.38adef0d@bahia> (raw)
In-Reply-To: <110bb988-4e22-1b2a-15dd-56e198d41923@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 9479 bytes --]
On Wed, 3 May 2017 16:19:20 +0200
Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com> wrote:
> On 5/3/2017 8:22 AM, Greg Kurz wrote:
> > s/Throttle/throttle
> >
> > On Tue, 2 May 2017 10:29:43 -0400
> > Pradeep Jagadeesh <pradeepkiruvale@gmail.com> wrote:
> >
> >> This patchset introduces a new io throttle structure. This will be
> >
> > s/patchset/patch
> OK
> >
> >> used in both block and fsdev devices.
> >>
> >> Signed-off-by: Pradeep Jagadeesh <pradeep.jagadeesh@huawei.com>
> >> ---
> >
> > Reviewed-by: Greg Kurz <groug@kaod.org>
> OK
> >
> >> qapi/block-core.json | 76 ++--------------------------------------------
> >> qapi/iothrottle.json | 86 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> >> 2 files changed, 89 insertions(+), 73 deletions(-)
> >> create mode 100644 qapi/iothrottle.json
> >>
> >> diff --git a/qapi/block-core.json b/qapi/block-core.json
> >> index 87fb747..93d346b 100644
> >> --- a/qapi/block-core.json
> >> +++ b/qapi/block-core.json
> >> @@ -6,6 +6,7 @@
> >>
> >> # QAPI common definitions
> >> { 'include': 'common.json' }
> >> +{ 'include': 'iothrottle.json' }
> >>
> >> ##
> >> # @SnapshotInfo:
> >> @@ -1760,84 +1761,13 @@
> >> #
> >> # @device: Block device name (deprecated, use @id instead)
> >> #
> >> -# @id: The name or QOM path of the guest device (since: 2.8)
> >> -#
> >> -# @bps: total throughput limit in bytes per second
> >> -#
> >> -# @bps_rd: read throughput limit in bytes per second
> >> -#
> >> -# @bps_wr: write throughput limit in bytes per second
> >> -#
> >> -# @iops: total I/O operations per second
> >> -#
> >> -# @iops_rd: read I/O operations per second
> >> -#
> >> -# @iops_wr: write I/O operations per second
> >> -#
> >> -# @bps_max: total throughput limit during bursts,
> >> -# in bytes (Since 1.7)
> >> -#
> >> -# @bps_rd_max: read throughput limit during bursts,
> >> -# in bytes (Since 1.7)
> >> -#
> >> -# @bps_wr_max: write throughput limit during bursts,
> >> -# in bytes (Since 1.7)
> >> -#
> >> -# @iops_max: total I/O operations per second during bursts,
> >> -# in bytes (Since 1.7)
> >> -#
> >> -# @iops_rd_max: read I/O operations per second during bursts,
> >> -# in bytes (Since 1.7)
> >> -#
> >> -# @iops_wr_max: write I/O operations per second during bursts,
> >> -# in bytes (Since 1.7)
> >> -#
> >> -# @bps_max_length: maximum length of the @bps_max burst
> >> -# period, in seconds. It must only
> >> -# be set if @bps_max is set as well.
> >> -# Defaults to 1. (Since 2.6)
> >> -#
> >> -# @bps_rd_max_length: maximum length of the @bps_rd_max
> >> -# burst period, in seconds. It must only
> >> -# be set if @bps_rd_max is set as well.
> >> -# Defaults to 1. (Since 2.6)
> >> -#
> >> -# @bps_wr_max_length: maximum length of the @bps_wr_max
> >> -# burst period, in seconds. It must only
> >> -# be set if @bps_wr_max is set as well.
> >> -# Defaults to 1. (Since 2.6)
> >> -#
> >> -# @iops_max_length: maximum length of the @iops burst
> >> -# period, in seconds. It must only
> >> -# be set if @iops_max is set as well.
> >> -# Defaults to 1. (Since 2.6)
> >> -#
> >> -# @iops_rd_max_length: maximum length of the @iops_rd_max
> >> -# burst period, in seconds. It must only
> >> -# be set if @iops_rd_max is set as well.
> >> -# Defaults to 1. (Since 2.6)
> >> -#
> >> -# @iops_wr_max_length: maximum length of the @iops_wr_max
> >> -# burst period, in seconds. It must only
> >> -# be set if @iops_wr_max is set as well.
> >> -# Defaults to 1. (Since 2.6)
> >> -#
> >> -# @iops_size: an I/O size in bytes (Since 1.7)
> >> -#
> >> # @group: throttle group name (Since 2.4)
> >> #
> >> # Since: 1.1
> >> ##
> >> { 'struct': 'BlockIOThrottle',
> >> - 'data': { '*device': 'str', '*id': 'str', 'bps': 'int', 'bps_rd': 'int',
> >> - 'bps_wr': 'int', 'iops': 'int', 'iops_rd': 'int', 'iops_wr': 'int',
> >> - '*bps_max': 'int', '*bps_rd_max': 'int',
> >> - '*bps_wr_max': 'int', '*iops_max': 'int',
> >> - '*iops_rd_max': 'int', '*iops_wr_max': 'int',
> >> - '*bps_max_length': 'int', '*bps_rd_max_length': 'int',
> >> - '*bps_wr_max_length': 'int', '*iops_max_length': 'int',
> >> - '*iops_rd_max_length': 'int', '*iops_wr_max_length': 'int',
> >> - '*iops_size': 'int', '*group': 'str' } }
> >> + 'base': 'IOThrottle',
> >> + 'data': { '*device': 'str', '*group': 'str' } }
> >>
> >> ##
> >> # @block-stream:
> >> diff --git a/qapi/iothrottle.json b/qapi/iothrottle.json
> >> new file mode 100644
> >> index 0000000..124ab40
> >> --- /dev/null
> >> +++ b/qapi/iothrottle.json
> >> @@ -0,0 +1,86 @@
> >> +# -*- Mode: Python -*-
> >> +
> >> +##
> >> +# == QAPI IOThrottle definitions
> >> +##
> >> +# @IOThrottle:
> >> +#
> >> +# A set of parameters describing iothrottle
> >
> > s/iothrottle/IO throttling/
> I completely taken off that sentence.
Hmm... I guess we still want a short description, like any other structure.
> >
> >> +#
> >> +# @id: The name or QOM path of the guest device (since: 2.8)
> >> +#
> >> +# @bps: total throughput limit in bytes per second
> >> +#
> >> +# @bps_rd: read throughput limit in bytes per second
> >> +#
> >> +# @bps_wr: write throughput limit in bytes per second
> >> +#
> >> +# @iops: total I/O operations per second
> >> +#
> >> +# @iops_rd: read I/O operations per second
> >> +#
> >> +# @iops_wr: write I/O operations per second
> >> +#
> >> +# @bps_max: total throughput limit during bursts,
> >> +# in bytes (Since 1.7)
> >> +#
> >> +# @bps_rd_max: read throughput limit during bursts,
> >> +# in bytes (Since 1.7)
> >> +#
> >> +# @bps_wr_max: write throughput limit during bursts,
> >> +# in bytes (Since 1.7)
> >> +#
> >> +# @iops_max: total I/O operations per second during bursts,
> >> +# in bytes (Since 1.7)
> >> +#
> >> +# @iops_rd_max: read I/O operations per second during bursts,
> >> +# in bytes (Since 1.7)
> >> +#
> >> +# @iops_wr_max: write I/O operations per second during bursts,
> >> +# in bytes (Since 1.7)
> >> +#
> >> +# @bps_max_length: maximum length of the @bps_max burst
> >> +# period, in seconds. It must only
> >> +# be set if @bps_max is set as well.
> >> +# Defaults to 1. (Since 2.6)
> >> +#
> >> +# @bps_rd_max_length: maximum length of the @bps_rd_max
> >> +# burst period, in seconds. It must only
> >> +# be set if @bps_rd_max is set as well.
> >> +# Defaults to 1. (Since 2.6)
> >> +#
> >> +# @bps_wr_max_length: maximum length of the @bps_wr_max
> >> +# burst period, in seconds. It must only
> >> +# be set if @bps_wr_max is set as well.
> >> +# Defaults to 1. (Since 2.6)
> >> +#
> >> +# @iops_max_length: maximum length of the @iops burst
> >> +# period, in seconds. It must only
> >> +# be set if @iops_max is set as well.
> >> +# Defaults to 1. (Since 2.6)
> >> +#
> >> +# @iops_rd_max_length: maximum length of the @iops_rd_max
> >> +# burst period, in seconds. It must only
> >> +# be set if @iops_rd_max is set as well.
> >> +# Defaults to 1. (Since 2.6)
> >> +#
> >> +# @iops_wr_max_length: maximum length of the @iops_wr_max
> >> +# burst period, in seconds. It must only
> >> +# be set if @iops_wr_max is set as well.
> >> +# Defaults to 1. (Since 2.6)
> >> +#
> >> +# @iops_size: an I/O size in bytes (Since 1.7)
> >> +#
> >> +#
> >> +# Since: 2.10
> >> +##
> >> +{ 'struct': 'IOThrottle',
> >> + 'data': { '*id': 'str', 'bps': 'int', 'bps_rd': 'int',
> >> + 'bps_wr': 'int', 'iops': 'int', 'iops_rd': 'int', 'iops_wr': 'int',
> >> + '*bps_max': 'int', '*bps_rd_max': 'int',
> >> + '*bps_wr_max': 'int', '*iops_max': 'int',
> >> + '*iops_rd_max': 'int', '*iops_wr_max': 'int',
> >> + '*bps_max_length': 'int', '*bps_rd_max_length': 'int',
> >> + '*bps_wr_max_length': 'int', '*iops_max_length': 'int',
> >> + '*iops_rd_max_length': 'int', '*iops_wr_max_length': 'int',
> >> + '*iops_size': 'int' } }
> >
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-05-03 17:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 14:29 [Qemu-devel] [PATCH v3 0/4] fsdev: qmp interface for io throttling Pradeep Jagadeesh
2017-05-02 14:29 ` [Qemu-devel] [PATCH v3 1/4] Throttle: Create IOThrottle structure Pradeep Jagadeesh
2017-05-02 21:56 ` Eric Blake
2017-05-03 6:22 ` Greg Kurz
2017-05-03 14:19 ` Pradeep Jagadeesh
2017-05-03 17:10 ` Greg Kurz [this message]
2017-05-02 14:29 ` [Qemu-devel] [PATCH v3 2/4] fsdev: QMP interface for throttling Pradeep Jagadeesh
2017-05-02 22:13 ` Eric Blake
2017-05-03 15:40 ` Pradeep Jagadeesh
2017-05-03 16:32 ` Eric Blake
2017-05-04 15:12 ` Pradeep Jagadeesh
2017-05-04 15:19 ` Eric Blake
2017-05-05 11:09 ` Pradeep Jagadeesh
2017-05-02 14:29 ` [Qemu-devel] [PATCH v3 3/4] qmp: refactor duplicate code Pradeep Jagadeesh
2017-05-02 22:15 ` Eric Blake
2017-05-03 17:21 ` Greg Kurz
2017-05-04 9:44 ` Pradeep Jagadeesh
2017-05-02 14:29 ` [Qemu-devel] [PATCH v3 4/4] throttle: factor out " Pradeep Jagadeesh
2017-05-02 15:03 ` [Qemu-devel] [PATCH v3 0/4] fsdev: qmp interface for io throttling no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170503191023.38adef0d@bahia \
--to=groug@kaod.org \
--cc=berto@igalia.com \
--cc=eblake@redhat.com \
--cc=jani.kokkonen@huawei.com \
--cc=pradeep.jagadeesh@huawei.com \
--cc=pradeepkiruvale@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).