From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d611L-0002rd-0w for qemu-devel@nongnu.org; Wed, 03 May 2017 16:37:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d611K-0002gs-8O for qemu-devel@nongnu.org; Wed, 03 May 2017 16:37:11 -0400 From: Eduardo Habkost Date: Wed, 3 May 2017 17:35:53 -0300 Message-Id: <20170503203604.31462-11-ehabkost@redhat.com> In-Reply-To: <20170503203604.31462-1-ehabkost@redhat.com> References: <20170503203604.31462-1-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH RESEND v2 10/21] sysbus-ahci: Remove user_creatable flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Laszlo Ersek , Thomas Huth , Alexander Graf , Markus Armbruster , Marcel Apfelbaum , Peter Maydell , John Snow , qemu-block@nongnu.org, Rob Herring , Alistair Francis , "Edgar E. Iglesias" The sysbus-ahci devices are supposed to be created and wired by code from other devices, like calxeda_init() and xlnx_zynqmp_realize(), and won't work with -device. Remove the user_creatable flag from the device class. Cc: John Snow Cc: qemu-block@nongnu.org Cc: Rob Herring Cc: Peter Maydell Cc: Alistair Francis Cc: "Edgar E. Iglesias" Cc: Marcel Apfelbaum Reviewed-by: Alistair Francis Acked-by: John Snow Acked-by: Marcel Apfelbaum Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * (none) --- hw/ide/ahci.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 7f10cda354..2ea1a282ef 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -1721,11 +1721,6 @@ static void sysbus_ahci_class_init(ObjectClass *klass, void *data) dc->props = sysbus_ahci_properties; dc->reset = sysbus_ahci_reset; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); - /* - * FIXME: Set only because we are not sure yet if this device - * will be outside the q35 sysbus whitelist. - */ - dc->user_creatable = true; } static const TypeInfo sysbus_ahci_info = { -- 2.11.0.259.g40922b1