From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54945) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6122-0003Wu-GX for qemu-devel@nongnu.org; Wed, 03 May 2017 16:37:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d611y-0003Li-HJ for qemu-devel@nongnu.org; Wed, 03 May 2017 16:37:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54366) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d611y-0003L1-C7 for qemu-devel@nongnu.org; Wed, 03 May 2017 16:37:50 -0400 From: Eduardo Habkost Date: Wed, 3 May 2017 17:36:04 -0300 Message-Id: <20170503203604.31462-22-ehabkost@redhat.com> In-Reply-To: <20170503203604.31462-1-ehabkost@redhat.com> References: <20170503203604.31462-1-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH RESEND v2 21/21] s390-pcibus: No need to set user_creatable=false explicitly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Laszlo Ersek , Thomas Huth , Alexander Graf , Markus Armbruster , Marcel Apfelbaum , Peter Maydell , Christian Borntraeger , Cornelia Huck , Frank Blaschka , Pierre Morel , Richard Henderson , Yi Min Zhao TYPE_S390_PCI_HOST_BRIDGE is a subclass of TYPE_PCI_HOST_BRIDGE, which is a subclass of TYPE_SYS_BUS_DEVICE. TYPE_SYS_BUS_DEVICE already sets user_creatable=false, so we don't require an explicit user_creatable=false assignment in s390_pcihost_class_init(). Cc: Alexander Graf Cc: Christian Borntraeger Cc: Cornelia Huck Cc: Frank Blaschka Cc: Laszlo Ersek Cc: Marcel Apfelbaum Cc: Markus Armbruster Cc: Peter Maydell Cc: Pierre Morel Cc: Richard Henderson Cc: Thomas Huth Cc: Yi Min Zhao Acked-by: Cornelia Huck Acked-by: Marcel Apfelbaum Signed-off-by: Eduardo Habkost --- Changes series v1 -> v2: * Previous patch was: "s390: Add FIXME for unexplained user_creatable=false line", but now we know we can remove the explicit user_creatable=false assignment --- hw/s390x/s390-pci-bus.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index b60a8f22b0..66a6fbeb8c 100644 --- a/hw/s390x/s390-pci-bus.c +++ b/hw/s390x/s390-pci-bus.c @@ -872,7 +872,6 @@ static void s390_pcihost_class_init(ObjectClass *klass, void *data) DeviceClass *dc = DEVICE_CLASS(klass); HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(klass); - dc->user_creatable = false; dc->reset = s390_pcihost_reset; k->init = s390_pcihost_init; hc->plug = s390_pcihost_hot_plug; -- 2.11.0.259.g40922b1