qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Laszlo Ersek <lersek@redhat.com>, Thomas Huth <thuth@redhat.com>,
	Alexander Graf <agraf@suse.de>,
	Markus Armbruster <armbru@redhat.com>,
	Marcel Apfelbaum <marcel@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH RESEND v2 04/21] iommu: Remove FIXME comment about user_creatable=true
Date: Wed,  3 May 2017 17:35:47 -0300	[thread overview]
Message-ID: <20170503203604.31462-5-ehabkost@redhat.com> (raw)
In-Reply-To: <20170503203604.31462-1-ehabkost@redhat.com>

amd-iommu and intel-iommu are really meant to be used with
-device, so they need user_creatable=true. Remove the FIXME
comment.

Cc: Marcel Apfelbaum <marcel@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Acked-by: Marcel Apfelbaum <marcel@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Changes v1 -> v2:
* (none)
---
 hw/i386/amd_iommu.c   | 5 +----
 hw/i386/intel_iommu.c | 5 +----
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
index 7b92c8c15a..efcc93cbfd 100644
--- a/hw/i386/amd_iommu.c
+++ b/hw/i386/amd_iommu.c
@@ -1186,10 +1186,7 @@ static void amdvi_class_init(ObjectClass *klass, void* data)
     dc->vmsd = &vmstate_amdvi;
     dc->hotpluggable = false;
     dc_class->realize = amdvi_realize;
-    /*
-     * FIXME: Set only because we are not sure yet if this device
-     * will be outside the q35 sysbus whitelist.
-     */
+    /* Supported by the pc-q35-* machine types */
     dc->user_creatable = true;
 }
 
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index 54187a04a4..327a46cd19 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -3009,10 +3009,7 @@ static void vtd_class_init(ObjectClass *klass, void *data)
     dc->hotpluggable = false;
     x86_class->realize = vtd_realize;
     x86_class->int_remap = vtd_int_remap;
-    /*
-     * FIXME: Set only because we are not sure yet if this device
-     * will be outside the q35 sysbus whitelist.
-     */
+    /* Supported by the pc-q35-* machine types */
     dc->user_creatable = true;
 }
 
-- 
2.11.0.259.g40922b1

  parent reply	other threads:[~2017-05-03 20:36 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03 20:35 [Qemu-devel] [PATCH RESEND v2 00/21] qdev/sysbus: Set user_creatable=false by default on sysbus Eduardo Habkost
2017-05-03 20:35 ` [Qemu-devel] [PATCH RESEND v2 01/21] qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable Eduardo Habkost
2017-05-15  8:31   ` Markus Armbruster
2017-05-03 20:35 ` [Qemu-devel] [PATCH RESEND v2 02/21] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE Eduardo Habkost
2017-05-05  7:36   ` Cornelia Huck
2017-05-05 16:54     ` Eduardo Habkost
2017-05-05 20:36       ` [Qemu-devel] [PATCH] fixup! " Eduardo Habkost
2017-05-08 10:51         ` Cornelia Huck
2017-05-15  8:43   ` [Qemu-devel] [PATCH RESEND v2 02/21] " Markus Armbruster
2017-05-03 20:35 ` [Qemu-devel] [PATCH RESEND v2 03/21] xen-backend: Remove FIXME comment about user_creatable flag Eduardo Habkost
2017-05-15  8:46   ` Markus Armbruster
2017-05-03 20:35 ` Eduardo Habkost [this message]
2017-05-03 20:49   ` [Qemu-devel] [PATCH RESEND v2 04/21] iommu: Remove FIXME comment about user_creatable=true Michael S. Tsirkin
2017-05-03 20:35 ` [Qemu-devel] [PATCH RESEND v2 05/21] fdc: Remove user_creatable flag from sysbus-fdc & SUNW, fdtwo Eduardo Habkost
2017-05-03 20:35 ` [Qemu-devel] [PATCH RESEND v2 06/21] pflash_cfi01: Remove user_creatable flag Eduardo Habkost
2017-05-03 20:35 ` [Qemu-devel] [PATCH RESEND v2 07/21] kvmclock: " Eduardo Habkost
2017-05-03 20:35 ` [Qemu-devel] [PATCH RESEND v2 08/21] ioapic: " Eduardo Habkost
2017-05-03 20:35 ` [Qemu-devel] [PATCH RESEND v2 09/21] kvmvapic: " Eduardo Habkost
2017-05-03 20:35 ` [Qemu-devel] [PATCH RESEND v2 10/21] sysbus-ahci: " Eduardo Habkost
2017-05-03 20:35 ` [Qemu-devel] [PATCH RESEND v2 11/21] allwinner-ahci: " Eduardo Habkost
2017-05-03 20:35 ` [Qemu-devel] [PATCH RESEND v2 12/21] isabus-bridge: " Eduardo Habkost
2017-05-03 20:35 ` [Qemu-devel] [PATCH RESEND v2 13/21] unimplemented-device: " Eduardo Habkost
2017-05-03 20:35 ` [Qemu-devel] [PATCH RESEND v2 14/21] fw_cfg: " Eduardo Habkost
2017-05-03 20:49   ` Michael S. Tsirkin
2017-05-03 20:35 ` [Qemu-devel] [PATCH RESEND v2 15/21] esp: " Eduardo Habkost
2017-05-03 20:35 ` [Qemu-devel] [PATCH RESEND v2 16/21] generic-sdhci: " Eduardo Habkost
2017-05-03 20:36 ` [Qemu-devel] [PATCH RESEND v2 17/21] hpet: " Eduardo Habkost
2017-05-03 20:36 ` [Qemu-devel] [PATCH RESEND v2 18/21] sysbus-ohci: " Eduardo Habkost
2017-05-03 20:36 ` [Qemu-devel] [PATCH RESEND v2 19/21] virtio-mmio: " Eduardo Habkost
2017-05-03 20:48   ` Michael S. Tsirkin
2017-05-03 20:36 ` [Qemu-devel] [PATCH RESEND v2 20/21] xen-sysdev: " Eduardo Habkost
2017-05-03 20:36 ` [Qemu-devel] [PATCH RESEND v2 21/21] s390-pcibus: No need to set user_creatable=false explicitly Eduardo Habkost
2017-05-12 18:44 ` [Qemu-devel] [PATCH RESEND v2 00/21] qdev/sysbus: Set user_creatable=false by default on sysbus Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170503203604.31462-5-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=agraf@suse.de \
    --cc=armbru@redhat.com \
    --cc=lersek@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).