From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d610v-0002Tz-8U for qemu-devel@nongnu.org; Wed, 03 May 2017 16:36:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d610u-00021h-9h for qemu-devel@nongnu.org; Wed, 03 May 2017 16:36:45 -0400 From: Eduardo Habkost Date: Wed, 3 May 2017 17:35:48 -0300 Message-Id: <20170503203604.31462-6-ehabkost@redhat.com> In-Reply-To: <20170503203604.31462-1-ehabkost@redhat.com> References: <20170503203604.31462-1-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH RESEND v2 05/21] fdc: Remove user_creatable flag from sysbus-fdc & SUNW, fdtwo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Laszlo Ersek , Thomas Huth , Alexander Graf , Markus Armbruster , Marcel Apfelbaum , Peter Maydell , John Snow , Kevin Wolf , Max Reitz , qemu-block@nongnu.org sysbus-fdc and SUNW,fdtwo devices need IRQs to be wired and mmio to be mapped, and can't be used with -device. Unset user_creatable on their device classes. Cc: John Snow Cc: Kevin Wolf Cc: Marcel Apfelbaum Cc: Max Reitz Cc: qemu-block@nongnu.org Cc: Thomas Huth Acked-by: John Snow Reviewed-by: Thomas Huth Acked-by: Marcel Apfelbaum Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Commit message rewrite only --- hw/block/fdc.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index 5c28a0b0ad..2e629b398b 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@ -2880,11 +2880,6 @@ static void sysbus_fdc_class_init(ObjectClass *klass, void *data) dc->props = sysbus_fdc_properties; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); - /* - * FIXME: Set only because we are not sure yet if this device - * will be outside the q35 sysbus whitelist. - */ - dc->user_creatable = true; } static const TypeInfo sysbus_fdc_info = { @@ -2911,11 +2906,6 @@ static void sun4m_fdc_class_init(ObjectClass *klass, void *data) dc->props = sun4m_fdc_properties; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); - /* - * FIXME: Set only because we are not sure yet if this device - * will be outside the q35 sysbus whitelist. - */ - dc->user_creatable = true; } static const TypeInfo sun4m_fdc_info = { -- 2.11.0.259.g40922b1