From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54458) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d610w-0002VV-KO for qemu-devel@nongnu.org; Wed, 03 May 2017 16:36:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d610v-00023m-MW for qemu-devel@nongnu.org; Wed, 03 May 2017 16:36:46 -0400 From: Eduardo Habkost Date: Wed, 3 May 2017 17:35:49 -0300 Message-Id: <20170503203604.31462-7-ehabkost@redhat.com> In-Reply-To: <20170503203604.31462-1-ehabkost@redhat.com> References: <20170503203604.31462-1-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH RESEND v2 06/21] pflash_cfi01: Remove user_creatable flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Laszlo Ersek , Thomas Huth , Alexander Graf , Markus Armbruster , Marcel Apfelbaum , Peter Maydell , Kevin Wolf , Max Reitz , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= TYPE_CFI_PFLASH01 devices need to be mapped by pflash_cfi01_register() (or equivalent) and can't be used with -device. Remove user_creatable from the device class. Cc: Kevin Wolf Cc: Max Reitz Cc: qemu-block@nongnu.org Cc: Laszlo Ersek Cc: Philippe Mathieu-Daud=C3=A9 Cc: Marcel Apfelbaum Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laszlo Ersek Acked-by: Marcel Apfelbaum Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Commit message rewrite only --- hw/block/pflash_cfi01.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index ef71956433..594d4cf6fe 100644 --- a/hw/block/pflash_cfi01.c +++ b/hw/block/pflash_cfi01.c @@ -927,11 +927,6 @@ static void pflash_cfi01_class_init(ObjectClass *kla= ss, void *data) dc->props =3D pflash_cfi01_properties; dc->vmsd =3D &vmstate_pflash; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); - /* - * FIXME: Set only because we are not sure yet if this device - * will be outside the q35 sysbus whitelist. - */ - dc->user_creatable =3D true; } =20 =20 --=20 2.11.0.259.g40922b1