qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, mst@redhat.com,
	jasowang@redhat.com, quintela@redhat.com, dovgaluk@ispras.ru,
	kraxel@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH v9 05/10] replay: fixed replay_enable_events
Date: Thu, 04 May 2017 11:42:05 +0300	[thread overview]
Message-ID: <20170504084205.7488.95093.stgit@PASHA-ISP> (raw)
In-Reply-To: <20170504084135.7488.24715.stgit@PASHA-ISP>

From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>

This patch fixes assignment to internal events_enabled variable.
Now it is set only in record/replay mode. This affects the behavior
of the external functions that check this flag.

Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
---
 replay/replay-events.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/replay/replay-events.c b/replay/replay-events.c
index 768b505f3d..e858254074 100644
--- a/replay/replay-events.c
+++ b/replay/replay-events.c
@@ -67,7 +67,9 @@ static void replay_run_event(Event *event)
 
 void replay_enable_events(void)
 {
-    events_enabled = true;
+    if (replay_mode != REPLAY_MODE_NONE) {
+        events_enabled = true;
+    }
 }
 
 bool replay_has_events(void)
@@ -141,7 +143,7 @@ void replay_add_event(ReplayAsyncEventKind event_kind,
 
 void replay_bh_schedule_event(QEMUBH *bh)
 {
-    if (replay_mode != REPLAY_MODE_NONE && events_enabled) {
+    if (events_enabled) {
         uint64_t id = replay_get_current_step();
         replay_add_event(REPLAY_ASYNC_EVENT_BH, bh, NULL, id);
     } else {
@@ -161,7 +163,7 @@ void replay_add_input_sync_event(void)
 
 void replay_block_event(QEMUBH *bh, uint64_t id)
 {
-    if (replay_mode != REPLAY_MODE_NONE && events_enabled) {
+    if (events_enabled) {
         replay_add_event(REPLAY_ASYNC_EVENT_BLOCK, bh, NULL, id);
     } else {
         qemu_bh_schedule(bh);

  parent reply	other threads:[~2017-05-04  8:42 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-04  8:41 [Qemu-devel] [PATCH v9 00/10] replay additions Pavel Dovgalyuk
2017-05-04  8:41 ` [Qemu-devel] [PATCH v9 01/10] block: implement bdrv_snapshot_goto for blkreplay Pavel Dovgalyuk
2017-05-04  8:41 ` [Qemu-devel] [PATCH v9 02/10] blkreplay: create temporary overlay for underlaying devices Pavel Dovgalyuk
2017-05-04  8:41 ` [Qemu-devel] [PATCH v9 03/10] replay: disable default snapshot for record/replay Pavel Dovgalyuk
2017-05-04  8:41 ` [Qemu-devel] [PATCH v9 04/10] replay: fix processing async events Pavel Dovgalyuk
2017-05-04 10:30   ` Paolo Bonzini
2017-05-04 12:32     ` Pavel Dovgalyuk
2017-05-04  8:42 ` Pavel Dovgalyuk [this message]
2017-05-04  8:42 ` [Qemu-devel] [PATCH v9 06/10] replay: fix save/load vm for non-empty queue Pavel Dovgalyuk
2017-05-04  9:33   ` Juan Quintela
2017-05-04 10:03     ` Pavel Dovgalyuk
2017-05-04 10:31   ` Paolo Bonzini
2017-05-04 11:13     ` Pavel Dovgalyuk
2017-05-04 11:52       ` Paolo Bonzini
2017-05-04 11:54         ` Pavel Dovgalyuk
2017-05-04 12:02           ` Paolo Bonzini
2017-05-04 12:10             ` Pavel Dovgalyuk
2017-05-04 12:32               ` Paolo Bonzini
2017-05-04 12:34                 ` Pavel Dovgalyuk
2017-05-04 12:52                   ` Paolo Bonzini
2017-05-04 13:02                     ` Pavel Dovgalyuk
2017-05-04 13:12                       ` Paolo Bonzini
2017-05-04 13:24                         ` Pavel Dovgalyuk
2017-05-04  8:42 ` [Qemu-devel] [PATCH v9 07/10] replay: added replay log format description Pavel Dovgalyuk
2017-05-04  8:42 ` [Qemu-devel] [PATCH v9 08/10] replay: make safe vmstop at record/replay Pavel Dovgalyuk
2017-05-04  8:42 ` [Qemu-devel] [PATCH v9 09/10] replay: save prior value of the host clock Pavel Dovgalyuk
2017-05-04  8:42 ` [Qemu-devel] [PATCH v9 10/10] icount: fixed saving/restoring of icount warp timers Pavel Dovgalyuk
2017-05-04  9:35 ` [Qemu-devel] [PATCH v9 00/10] replay additions no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170504084205.7488.95093.stgit@PASHA-ISP \
    --to=pavel.dovgaluk@ispras.ru \
    --cc=dovgaluk@ispras.ru \
    --cc=jasowang@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).