From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6M21-0002j6-5A for qemu-devel@nongnu.org; Thu, 04 May 2017 15:03:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6M1x-0007y6-S6 for qemu-devel@nongnu.org; Thu, 04 May 2017 15:03:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39982) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d6M1x-0007wh-F9 for qemu-devel@nongnu.org; Thu, 04 May 2017 15:03:13 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5B2A76198D for ; Thu, 4 May 2017 19:03:12 +0000 (UTC) Date: Thu, 4 May 2017 20:03:06 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170504190306.GB2611@work-vm> References: <20170425220451.6028-1-quintela@redhat.com> <20170425220451.6028-9-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170425220451.6028-9-quintela@redhat.com> Subject: Re: [Qemu-devel] [PATCH 08/41] migration: Move page_cache.c to migration/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com * Juan Quintela (quintela@redhat.com) wrote: > It is only used by migration, so move it there. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > Makefile.objs | 1 - > migration/Makefile.objs | 2 +- > page_cache.c => migration/page_cache.c | 0 > {include/migration => migration}/page_cache.h | 0 > tests/Makefile.include | 2 +- > 5 files changed, 2 insertions(+), 3 deletions(-) > rename page_cache.c => migration/page_cache.c (100%) > rename {include/migration => migration}/page_cache.h (100%) > > diff --git a/Makefile.objs b/Makefile.objs > index 6167e7b..2100845 100644 > --- a/Makefile.objs > +++ b/Makefile.objs > @@ -49,7 +49,6 @@ common-obj-$(CONFIG_POSIX) += os-posix.o > common-obj-$(CONFIG_LINUX) += fsdev/ > > common-obj-y += migration/ > -common-obj-y += page_cache.o #aio.o > > common-obj-$(CONFIG_SPICE) += spice-qemu-char.o > > diff --git a/migration/Makefile.objs b/migration/Makefile.objs > index c83ca92..ce8ce12 100644 > --- a/migration/Makefile.objs > +++ b/migration/Makefile.objs > @@ -1,7 +1,7 @@ > common-obj-y += migration.o socket.o fd.o exec.o > common-obj-y += tls.o channel.o > common-obj-y += colo-comm.o colo.o colo-failover.o > -common-obj-y += vmstate.o > +common-obj-y += vmstate.o page_cache.o > common-obj-y += qemu-file.o > common-obj-y += qemu-file-channel.o > common-obj-y += xbzrle.o postcopy-ram.o > diff --git a/page_cache.c b/migration/page_cache.c > similarity index 100% > rename from page_cache.c > rename to migration/page_cache.c > diff --git a/include/migration/page_cache.h b/migration/page_cache.h > similarity index 100% > rename from include/migration/page_cache.h > rename to migration/page_cache.h > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 579ec07..0f98c04 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -549,7 +549,7 @@ tests/test-thread-pool$(EXESUF): tests/test-thread-pool.o $(test-block-obj-y) > tests/test-iov$(EXESUF): tests/test-iov.o $(test-util-obj-y) > tests/test-hbitmap$(EXESUF): tests/test-hbitmap.o $(test-util-obj-y) > tests/test-x86-cpuid$(EXESUF): tests/test-x86-cpuid.o > -tests/test-xbzrle$(EXESUF): tests/test-xbzrle.o migration/xbzrle.o page_cache.o $(test-util-obj-y) > +tests/test-xbzrle$(EXESUF): tests/test-xbzrle.o migration/xbzrle.o migration/page_cache.o $(test-util-obj-y) > tests/test-cutils$(EXESUF): tests/test-cutils.o util/cutils.o > tests/test-int128$(EXESUF): tests/test-int128.o > tests/rcutorture$(EXESUF): tests/rcutorture.o $(test-util-obj-y) > -- > 2.9.3 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK