qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] tests: Remove redundant assignment
@ 2017-05-05  2:04 Fam Zheng
  2017-05-05  2:17 ` Eric Blake
  2017-05-05  6:30 ` Michael Tokarev
  0 siblings, 2 replies; 3+ messages in thread
From: Fam Zheng @ 2017-05-05  2:04 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-trivial

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/postcopy-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c
index de35a18..e86f876 100644
--- a/tests/postcopy-test.c
+++ b/tests/postcopy-test.c
@@ -41,7 +41,7 @@ static bool ufd_version_check(void)
     struct uffdio_api api_struct;
     uint64_t ioctl_mask;
 
-    int ufd = ufd = syscall(__NR_userfaultfd, O_CLOEXEC);
+    int ufd = syscall(__NR_userfaultfd, O_CLOEXEC);
 
     if (ufd == -1) {
         g_test_message("Skipping test: userfaultfd not available");
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] tests: Remove redundant assignment
  2017-05-05  2:04 [Qemu-devel] [PATCH] tests: Remove redundant assignment Fam Zheng
@ 2017-05-05  2:17 ` Eric Blake
  2017-05-05  6:30 ` Michael Tokarev
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2017-05-05  2:17 UTC (permalink / raw)
  To: Fam Zheng, qemu-devel; +Cc: qemu-trivial

[-- Attachment #1: Type: text/plain, Size: 873 bytes --]

On 05/04/2017 09:04 PM, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/postcopy-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

> diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c
> index de35a18..e86f876 100644
> --- a/tests/postcopy-test.c
> +++ b/tests/postcopy-test.c
> @@ -41,7 +41,7 @@ static bool ufd_version_check(void)
>      struct uffdio_api api_struct;
>      uint64_t ioctl_mask;
>  
> -    int ufd = ufd = syscall(__NR_userfaultfd, O_CLOEXEC);
> +    int ufd = syscall(__NR_userfaultfd, O_CLOEXEC);
>  
>      if (ufd == -1) {
>          g_test_message("Skipping test: userfaultfd not available");
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] tests: Remove redundant assignment
  2017-05-05  2:04 [Qemu-devel] [PATCH] tests: Remove redundant assignment Fam Zheng
  2017-05-05  2:17 ` Eric Blake
@ 2017-05-05  6:30 ` Michael Tokarev
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Tokarev @ 2017-05-05  6:30 UTC (permalink / raw)
  To: Fam Zheng, qemu-devel; +Cc: qemu-trivial

That's a good one :)

Applied to -trivial, thanks!

/mjt

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-05  6:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-05  2:04 [Qemu-devel] [PATCH] tests: Remove redundant assignment Fam Zheng
2017-05-05  2:17 ` Eric Blake
2017-05-05  6:30 ` Michael Tokarev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).