From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55410) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6eZV-0006NN-FE for qemu-devel@nongnu.org; Fri, 05 May 2017 10:51:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6eZR-0003zk-HF for qemu-devel@nongnu.org; Fri, 05 May 2017 10:51:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25008) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d6eZQ-0003zY-SM for qemu-devel@nongnu.org; Fri, 05 May 2017 10:51:01 -0400 Date: Fri, 5 May 2017 15:50:49 +0100 From: "Daniel P. Berrange" Message-ID: <20170505145049.GM12773@redhat.com> Reply-To: "Daniel P. Berrange" References: <1493726062-31743-1-git-send-email-thuth@redhat.com> <20170505144837.GB14316@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170505144837.GB14316@stefanha-x1.localdomain> Subject: Re: [Qemu-devel] [PATCH] Mark legacy option '-no-kvm' as deprecated List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Thomas Huth , Paolo Bonzini , qemu-devel@nongnu.org On Fri, May 05, 2017 at 03:48:37PM +0100, Stefan Hajnoczi wrote: > On Tue, May 02, 2017 at 01:54:22PM +0200, Thomas Huth wrote: > > '-no-kvm' was just a legacy convenience option for the users of > > qemu-kvm, it never made sense in the normal QEMU tree since TCG is > > the default here anyway. The option has also never been specified > > in the QEMU docs and in the '--help' list, so likely hardly anybody > > knows about this option at all. I think we could get rid of this > > without bothering anybody nowadays, but just in case, let's print > > out a warning for a couple of releases first. > > > > Signed-off-by: Thomas Huth > > --- > > vl.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/vl.c b/vl.c > > index d5ec87e..2d44621 100644 > > --- a/vl.c > > +++ b/vl.c > > @@ -3709,7 +3709,9 @@ int main(int argc, char **argv, char **envp) > > exit(1); > > } > > break; > > - case QEMU_OPTION_no_kvm: > > + case QEMU_OPTION_no_kvm: > > + error_report("'-no-kvm' is depreacted, please use " > > s/depreacted/deprecated/ Should we have an dedicated 'error_deprecated(oldfeat, newfeat)' method that prints a standardized message, as well as a -no-deprecated flag that turns off all the deprecation warnings. There's nothing more annoying than an application that insists on spewing warnings to stdout that you know about, but aren't in a position to address any time soon. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|