From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>,
Eric Blake <eblake@redhat.com>,
Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH v2 0/3] string-input-visitor: Support enum/bool alternate types
Date: Fri, 5 May 2017 17:11:25 -0300 [thread overview]
Message-ID: <20170505201128.12099-1-ehabkost@redhat.com> (raw)
v1 was originally part of the following series:
[PATCH 0/4] x86: Support "-cpu feature=force"
But as I am not sure yet "feature=force" is the right way to go,
I decided to send only the string-input-visitor alternate
support, in case the QAPI maintainers want to merge it anyway.
Changes v1 -> v2:
* Updated string_input_visitor_new() documentation
to mention alternate support (Markus Armbruster)
* Detect ambiguous alternates at runtime. Test case included.
* Removed support for integers. We don't need it yet, and
it would require sorting out the parse_str() mess.
* Change supported_qtypes to uint32_t (Eric Blake)
* Replace assert() on all generated visitor functions with a
single QEMU_BUILD_BUG_ON() on visit_start_alternate()
(Eric Blake)
* Extra spaces around "|" on generated visitor code
(Eric Blake)
* Don't use bitops.h and just use (1U << QTYPE_FOO)
(Markus Armbruster)
* Update tests/qapi-schema/qapi-schema-test.out to match
qapi-schema-test.json updates
* New patch: qapi: Add enum_table[] parameter to start_alternate
(needed to detect ambiguous alternates)
* Code indentation fix (Markus Armbruster)
Eduardo Habkost (3):
visitor: Add 'supported_qtypes' parameter to visit_start_alternate()
qapi: Add enum_table[] parameter to start_alternate
string-input-visitor: Support alternate types
include/qapi/visitor.h | 13 ++++-
include/qapi/visitor-impl.h | 4 +-
scripts/qapi-visit.py | 17 ++++--
include/qapi/string-input-visitor.h | 6 +-
qapi/qapi-visit-core.c | 12 +++-
qapi/qapi-clone-visitor.c | 4 +-
qapi/qapi-dealloc-visitor.c | 4 +-
qapi/qobject-input-visitor.c | 7 ++-
qapi/string-input-visitor.c | 99 +++++++++++++++++++++++++++++----
tests/test-string-input-visitor.c | 76 +++++++++++++++++++++++++
qapi/trace-events | 2 +-
tests/qapi-schema/qapi-schema-test.json | 8 +++
tests/qapi-schema/qapi-schema-test.out | 9 +++
13 files changed, 234 insertions(+), 27 deletions(-)
--
2.11.0.259.g40922b1
next reply other threads:[~2017-05-05 20:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 20:11 Eduardo Habkost [this message]
2017-05-05 20:11 ` [Qemu-devel] [PATCH v2 1/3] visitor: Add 'supported_qtypes' parameter to visit_start_alternate() Eduardo Habkost
2017-05-05 20:26 ` Eric Blake
2017-05-10 13:16 ` Markus Armbruster
2017-05-10 21:10 ` Eduardo Habkost
2017-05-11 7:04 ` Markus Armbruster
2017-05-05 20:11 ` [Qemu-devel] [PATCH v2 2/3] qapi: Add enum_table[] parameter to start_alternate Eduardo Habkost
2017-05-05 20:45 ` Eric Blake
2017-05-05 20:51 ` Eduardo Habkost
2017-05-10 13:34 ` Markus Armbruster
2017-05-10 13:38 ` Eduardo Habkost
2017-05-05 20:11 ` [Qemu-devel] [PATCH v2 3/3] string-input-visitor: Support alternate types Eduardo Habkost
2017-05-05 20:53 ` Eric Blake
2017-05-05 21:09 ` Eduardo Habkost
2017-05-10 13:45 ` Markus Armbruster
2017-05-10 13:43 ` Markus Armbruster
2017-05-05 20:42 ` [Qemu-devel] [PATCH v2 0/3] string-input-visitor: Support enum/bool " no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170505201128.12099-1-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).