From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Riku Voipio <riku.voipio@iki.fi>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] syscall: fix compiler warnings (clang 5)
Date: Fri, 5 May 2017 21:41:06 -0300 [thread overview]
Message-ID: <20170506004106.3291-1-f4bug@amsat.org> (raw)
static code analyzer complain:
linux-user/syscall.c:5575:9: warning: Dereference of undefined pointer value
if (*host_rt_dev_ptr != 0) {
^~~~~~~~~~~~~~~~
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
linux-user/syscall.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index cec8428589..c541e22693 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -5526,7 +5526,7 @@ static abi_long do_ioctl_rt(const IOCTLEntry *ie, uint8_t *buf_temp,
int target_size;
void *argptr;
abi_ulong *target_rt_dev_ptr;
- unsigned long *host_rt_dev_ptr;
+ unsigned long *host_rt_dev_ptr = NULL;
abi_long ret;
int i;
@@ -5572,7 +5572,7 @@ static abi_long do_ioctl_rt(const IOCTLEntry *ie, uint8_t *buf_temp,
unlock_user(argptr, arg, 0);
ret = get_errno(safe_ioctl(fd, ie->host_cmd, buf_temp));
- if (*host_rt_dev_ptr != 0) {
+ if (host_rt_dev_ptr != NULL && *host_rt_dev_ptr != 0) {
unlock_user((void *)*host_rt_dev_ptr,
*target_rt_dev_ptr, 0);
}
--
2.11.0
next reply other threads:[~2017-05-06 0:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-06 0:41 Philippe Mathieu-Daudé [this message]
2017-05-10 12:32 ` [Qemu-devel] [PATCH] syscall: fix compiler warnings (clang 5) Laurent Vivier
2017-05-10 14:38 ` Philippe Mathieu-Daudé
2017-05-10 19:41 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170506004106.3291-1-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).