qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Igor Mitsyanko <i.mitsyanko@gmail.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Subject: [Qemu-devel] [PATCH 2/3] hw/arm/exynos: Declare local variables in some order
Date: Sat,  6 May 2017 17:24:13 +0200	[thread overview]
Message-ID: <20170506152414.8704-3-krzk@kernel.org> (raw)
In-Reply-To: <20170506152414.8704-1-krzk@kernel.org>

Bring some more readability by declaring local function variables, first
initialized ones and then the rest (with reversed-christmas-tree order).

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 hw/arm/exynos4210.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c
index 0da877f8db0a..27a7bf28a5a9 100644
--- a/hw/arm/exynos4210.c
+++ b/hw/arm/exynos4210.c
@@ -162,12 +162,12 @@ static uint64_t exynos4210_calc_affinity(int cpu)
 
 Exynos4210State *exynos4210_init(MemoryRegion *system_mem)
 {
-    int i, n;
     Exynos4210State *s = g_new(Exynos4210State, 1);
     qemu_irq gate_irq[EXYNOS4210_NCPUS][EXYNOS4210_IRQ_GATE_NINPUTS];
-    DeviceState *dev;
     SysBusDevice *busdev;
     ObjectClass *cpu_oc;
+    DeviceState *dev;
+    int i, n;
 
     cpu_oc = cpu_class_by_name(TYPE_ARM_CPU, "cortex-a9");
     assert(cpu_oc);
-- 
2.9.3

  parent reply	other threads:[~2017-05-06 15:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-06 15:24 [Qemu-devel] [PATCH 0/3] hw/arm/exynos: QOM-ify the SoC Krzysztof Kozlowski
2017-05-06 15:24 ` [Qemu-devel] [PATCH 1/3] hw/arm/exynos: Move RAM initialization next boards Krzysztof Kozlowski
2017-05-06 16:05   ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2017-05-06 16:12     ` Krzysztof Kozlowski
2017-05-06 15:24 ` Krzysztof Kozlowski [this message]
2017-05-06 16:06   ` [Qemu-devel] [PATCH 2/3] hw/arm/exynos: Declare local variables in some order Philippe Mathieu-Daudé
2017-05-06 15:24 ` [Qemu-devel] [PATCH 3/3] hw/arm/exynos: QOM-ify the SoC Krzysztof Kozlowski
2017-05-06 16:07   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170506152414.8704-3-krzk@kernel.org \
    --to=krzk@kernel.org \
    --cc=i.mitsyanko@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).