From: Jeff Cody <jcody@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, jsnow@redhat.com,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 01/11] blockjob: remove unnecessary check
Date: Tue, 9 May 2017 12:23:54 -0400 [thread overview]
Message-ID: <20170509162354.GC16494@localhost.localdomain> (raw)
In-Reply-To: <20170508141310.8674-2-pbonzini@redhat.com>
On Mon, May 08, 2017 at 04:13:00PM +0200, Paolo Bonzini wrote:
> !job is always checked prior to the call, drop it from here.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> blockjob.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/blockjob.c b/blockjob.c
> index 6e489327ff..23022b3331 100644
> --- a/blockjob.c
> +++ b/blockjob.c
> @@ -480,7 +480,7 @@ static bool block_job_should_pause(BlockJob *job)
>
> bool block_job_user_paused(BlockJob *job)
> {
> - return job ? job->user_paused : 0;
> + return job->user_paused;
> }
>
> void coroutine_fn block_job_pause_point(BlockJob *job)
> --
> 2.12.2
>
>
Reviewed-by: Jeff Cody <jcody@redhat.com>
next prev parent reply other threads:[~2017-05-09 16:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 14:12 [Qemu-devel] [PATCH v2 00/11] Preparation for block job mutex Paolo Bonzini
2017-05-08 14:13 ` [Qemu-devel] [PATCH 01/11] blockjob: remove unnecessary check Paolo Bonzini
2017-05-09 16:23 ` Jeff Cody [this message]
2017-05-08 14:13 ` [Qemu-devel] [PATCH 02/11] blockjob: remove iostatus_reset callback Paolo Bonzini
2017-05-09 16:26 ` Jeff Cody
2017-05-08 14:13 ` [Qemu-devel] [PATCH 03/11] blockjob: introduce block_job_early_fail Paolo Bonzini
2017-05-09 16:37 ` Jeff Cody
2017-05-08 14:13 ` [Qemu-devel] [PATCH 04/11] blockjob: introduce block_job_pause/resume_all Paolo Bonzini
2017-05-09 17:00 ` Jeff Cody
2017-05-08 14:13 ` [Qemu-devel] [PATCH 05/11] blockjob: separate monitor and blockjob APIs Paolo Bonzini
2017-05-09 17:06 ` Jeff Cody
2017-05-09 17:09 ` Paolo Bonzini
2017-05-08 14:13 ` [Qemu-devel] [PATCH 06/11] blockjob: move iostatus reset inside block_job_user_resume Paolo Bonzini
2017-05-09 17:10 ` Jeff Cody
2017-05-08 14:13 ` [Qemu-devel] [PATCH 07/11] blockjob: introduce block_job_cancel_async, check iostatus invariants Paolo Bonzini
2017-05-08 14:13 ` [Qemu-devel] [PATCH 08/11] blockjob: group BlockJob transaction functions together Paolo Bonzini
2017-05-08 14:13 ` [Qemu-devel] [PATCH 09/11] blockjob: strengthen a bit test-blockjob-txn Paolo Bonzini
2017-05-08 14:13 ` [Qemu-devel] [PATCH 10/11] blockjob: reorganize block_job_completed_txn_abort Paolo Bonzini
2017-05-08 14:13 ` [Qemu-devel] [PATCH 11/11] blockjob: use deferred_to_main_loop to indicate the coroutine has ended Paolo Bonzini
2017-05-21 13:17 ` [Qemu-devel] [PATCH v2 00/11] Preparation for block job mutex Paolo Bonzini
2017-05-22 9:09 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-05-23 1:57 ` [Qemu-devel] " Jeff Cody
-- strict thread matches above, loose matches on Subject: below --
2017-04-19 14:42 [Qemu-devel] [PATCH for 2.10 " Paolo Bonzini
2017-04-19 14:42 ` [Qemu-devel] [PATCH 01/11] blockjob: remove unnecessary check Paolo Bonzini
2017-04-19 15:48 ` Eric Blake
2017-04-19 16:12 ` Paolo Bonzini
2017-04-19 16:16 ` Eric Blake
2017-04-24 23:19 ` John Snow
2017-04-26 8:36 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170509162354.GC16494@localhost.localdomain \
--to=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).