From: Manos Pitsidianakis <el13635@mail.ntua.gr>
To: qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] block: curl: Allow passing cookies via QCryptoSecret
Date: Tue, 9 May 2017 22:43:44 +0300 [thread overview]
Message-ID: <20170509194344.za4abntjp3tkrilt@post> (raw)
In-Reply-To: <20170509154439.GA16494@localhost.localdomain>
On Thu, May 04, 2017 at 04:00:06PM +0200, Peter Krempa wrote:
> + cookie_secret = qemu_opt_get(opts, CURL_BLOCK_OPT_COOKIE_SECRET);
> +
> + if (cookie && cookie_secret) {
> + error_setg(errp,
> + "curl driver cannot handle both cookie and cookie secret");
> + goto out_noclean;
> + }
> +
> + if (cookie_secret) {
> + s->cookie = qcrypto_secret_lookup_as_utf8(cookie_secret, errp);
> + if (!s->cookie) {
> + goto out_noclean;
> + }
> + } else {
> + s->cookie = g_strdup(cookie);
> + }
There's no check here for if both cookie and cookie_secret are NULL.
next prev parent reply other threads:[~2017-05-09 19:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 14:00 [Qemu-devel] [PATCH] block: curl: Allow passing cookies via QCryptoSecret Peter Krempa
2017-05-04 14:22 ` Eric Blake
2017-05-04 14:34 ` Daniel P. Berrange
2017-05-09 15:06 ` [Qemu-devel] [Qemu-block] " Kevin Wolf
2017-05-09 15:44 ` Jeff Cody
2017-05-09 19:43 ` Manos Pitsidianakis [this message]
2017-05-09 19:52 ` Eric Blake
2017-05-09 20:03 ` Manos Pitsidianakis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170509194344.za4abntjp3tkrilt@post \
--to=el13635@mail.ntua.gr \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).