qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
	qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v8 3/4] qemu-img: introduce --target-image-opts for 'convert' command
Date: Wed, 10 May 2017 09:57:10 +0800	[thread overview]
Message-ID: <20170510015710.GC19890@lemon.lan> (raw)
In-Reply-To: <20170509094837.22852-4-berrange@redhat.com>

On Tue, 05/09 10:48, Daniel P. Berrange wrote:
> The '--image-opts' flag indicates whether the source filename
> includes options. The target filename has to remain in the
> plain filename format though, since it needs to be passed to
> bdrv_create().  When using --skip-create though, it would be
> possible to use image-opts syntax. This adds --target-image-opts
> to indicate that the target filename includes options. Currently
> this mandates use of the --skip-create flag too.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>

Reviewed-by: Fam Zheng <famz@redhat.com>

  reply	other threads:[~2017-05-10  1:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-09  9:48 [Qemu-devel] [PATCH v8 0/4] Improve convert and dd commands Daniel P. Berrange
2017-05-09  9:48 ` [Qemu-devel] [PATCH v8 1/4] qemu-img: add support for --object with 'dd' command Daniel P. Berrange
2017-05-09  9:48 ` [Qemu-devel] [PATCH v8 2/4] qemu-img: fix --image-opts usage with dd command Daniel P. Berrange
2017-05-09  9:48 ` [Qemu-devel] [PATCH v8 3/4] qemu-img: introduce --target-image-opts for 'convert' command Daniel P. Berrange
2017-05-10  1:57   ` Fam Zheng [this message]
2017-05-09  9:48 ` [Qemu-devel] [PATCH v8 4/4] qemu-img: copy *key-secret opts when opening newly created files Daniel P. Berrange
2017-05-12 17:41 ` [Qemu-devel] [PATCH v8 0/4] Improve convert and dd commands Max Reitz
2017-05-15 10:40   ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170510015710.GC19890@lemon.lan \
    --to=famz@redhat.com \
    --cc=berrange@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).