qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
	mdroth@linux.vnet.ibm.com, bharata@linux.vnet.ibm.com,
	agraf@suse.de, aik@ozlabs.ru, sjitindarsingh@gmail.com,
	mark.cave-ayland@ilande.co.uk, sam.bobroff@au1.ibm.com,
	nikunj@linux.vnet.ibm.com, clg@kaod.org,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL 05/23] cpus: Fix CPU unplug for MTTCG
Date: Thu, 11 May 2017 14:14:08 +1000	[thread overview]
Message-ID: <20170511041426.6488-6-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20170511041426.6488-1-david@gibson.dropbear.id.au>

From: Bharata B Rao <bharata@linux.vnet.ibm.com>

Ensure that the unplugged CPU thread is destroyed and the waiting
thread is notified about it. This is needed for CPU unplug to work
correctly in MTTCG mode.

Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 cpus.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/cpus.c b/cpus.c
index 740b8dc..79f780b 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1483,6 +1483,12 @@ static void *qemu_tcg_cpu_thread_fn(void *arg)
                 /* Ignore everything else? */
                 break;
             }
+        } else if (cpu->unplug) {
+            qemu_tcg_destroy_vcpu(cpu);
+            cpu->created = false;
+            qemu_cond_signal(&qemu_cpu_cond);
+            qemu_mutex_unlock_iothread();
+            return NULL;
         }
 
         atomic_mb_set(&cpu->exit_request, 0);
-- 
2.9.3

  parent reply	other threads:[~2017-05-11  4:14 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-11  4:14 [Qemu-devel] [PULL 00/23] ppc-for-2.10 queue 20170511 David Gibson
2017-05-11  4:14 ` [Qemu-devel] [PULL 01/23] ppc/pnv: restrict BMC object to the BMC simulator David Gibson
2017-05-11  4:14 ` [Qemu-devel] [PULL 02/23] target/ppc: Emulate LL/SC using cmpxchg helpers David Gibson
2017-05-11  4:14 ` [Qemu-devel] [PULL 03/23] cputlb: handle first atomic write to the page David Gibson
2017-05-11  4:14 ` [Qemu-devel] [PULL 04/23] target/ppc: Generate fence operations David Gibson
2017-05-11  4:14 ` David Gibson [this message]
2017-05-11  4:14 ` [Qemu-devel] [PULL 06/23] tcg: enable MTTCG by default for PPC64 on x86 David Gibson
2017-05-11  4:14 ` [Qemu-devel] [PULL 07/23] target/ppc: do not reset reserve_addr in exec_enter David Gibson
2017-05-11  4:14 ` [Qemu-devel] [PULL 08/23] ppc/xics: Fix stale irq->status bits after get David Gibson
2017-05-11  4:14 ` [Qemu-devel] [PULL 09/23] ppc/xics: preserve P and Q bits for KVM IRQs David Gibson
2017-05-11  4:14 ` [Qemu-devel] [PULL 10/23] Add QemuMacDrivers as submodule David Gibson
2017-05-11  4:14 ` [Qemu-devel] [PULL 11/23] Add QemuMacDrivers qemu_vga.ndrv revision d4e7d7a built " David Gibson
2017-05-11  4:14 ` [Qemu-devel] [PULL 12/23] ppc: add qemu_vga.ndrv ROM to fw_cfg interface for OldWorld Macs David Gibson
2017-05-11  4:14 ` [Qemu-devel] [PULL 13/23] ppc: add qemu_vga.ndrv ROM to fw_cfg interface for NewWorld Macs David Gibson
2017-05-11  4:14 ` [Qemu-devel] [PULL 14/23] target/ppc: Set UPRT and GTSE on all cpus in H_REGISTER_PROCESS_TABLE David Gibson
2017-05-11  4:14 ` [Qemu-devel] [PULL 15/23] target/ppc: Update tlbie to check privilege level based on GTSE David Gibson
2017-05-11  4:14 ` [Qemu-devel] [PULL 16/23] target/ppc: Change tlbie invalid fields for POWER9 support David Gibson
2017-05-11  4:14 ` [Qemu-devel] [PULL 17/23] target/ppc: Implement ISA V3.00 radix page fault handler David Gibson
2017-05-11  4:14 ` [Qemu-devel] [PULL 18/23] target/ppc: Enable RADIX mmu mode for pseries TCG guest David Gibson
2017-05-11  4:14 ` [Qemu-devel] [PULL 19/23] ppc: xics: fix compilation with CentOS 6 David Gibson
2017-05-11  4:14 ` [Qemu-devel] [PULL 20/23] spapr: Don't accidentally advertise HTM support on POWER9 David Gibson
2017-05-11  4:14 ` [Qemu-devel] [PULL 21/23] target/ppc: Allow workarounds for POWER9 DD1 David Gibson
2017-05-11  4:14 ` [Qemu-devel] [PULL 22/23] pnv: Fix build failures on some host platforms David Gibson
2017-05-11  4:14 ` [Qemu-devel] [PULL 23/23] target/ppc: Avoid printing wrong aliases in CPU help text David Gibson
2017-05-15 13:04 ` [Qemu-devel] [PULL 00/23] ppc-for-2.10 queue 20170511 Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170511041426.6488-6-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=clg@kaod.org \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=nikunj@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=sam.bobroff@au1.ibm.com \
    --cc=sjitindarsingh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).