From: David Gibson <david@gibson.dropbear.id.au>
To: Laurent Vivier <lvivier@redhat.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 7/8] target/ppc: optimize various functions using extract op
Date: Fri, 12 May 2017 15:13:13 +1000 [thread overview]
Message-ID: <20170512051313.GB12908@umbus.fritz.box> (raw)
In-Reply-To: <5386fd20-8d13-408a-5b12-ba9468541e50@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On Thu, May 11, 2017 at 10:46:01AM +0200, Laurent Vivier wrote:
> On 11/05/2017 02:41, David Gibson wrote:
> > On Wed, May 10, 2017 at 05:05:34PM -0300, Philippe Mathieu-Daudé wrote:
> >> Applied using Coccinelle script.
> >>
> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >
> > Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
>
> David, look at Nikunj's comments: only the two first changes are correct.
>
> 'andi" uses a mask, but extract uses a 'width'. Philippe's changes work
> only when mask = 1.
Oops, that was sloppy of me, sorry.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-05-12 5:17 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 20:05 [Qemu-devel] [PATCH 0/8] optimize various tcg_gen() functions using extract op Philippe Mathieu-Daudé
2017-05-10 20:05 ` [Qemu-devel] [PATCH 1/8] coccinelle: add a script to optimize tcg op using tcg_gen_extract() Philippe Mathieu-Daudé
2017-05-10 20:12 ` Eric Blake
2017-05-10 20:23 ` Philippe Mathieu-Daudé
2017-05-10 20:19 ` Richard Henderson
2017-05-10 20:23 ` Eric Blake
2017-05-10 21:27 ` Philippe Mathieu-Daudé
2017-05-10 23:52 ` [Qemu-devel] [RFC PATCH v2] " Philippe Mathieu-Daudé
2017-05-11 0:13 ` Philippe Mathieu-Daudé
2017-05-11 9:03 ` Markus Armbruster
2017-05-12 2:01 ` Philippe Mathieu-Daudé
2017-05-12 2:04 ` Philippe Mathieu-Daudé
2017-05-15 7:04 ` Markus Armbruster
2017-05-10 20:05 ` [Qemu-devel] [PATCH 2/8] target/arm: optimize smul_dual() and neon_trn_u8() using extract op Philippe Mathieu-Daudé
2017-05-10 20:15 ` Eric Blake
2017-05-12 2:49 ` Philippe Mathieu-Daudé
2017-05-10 20:20 ` Richard Henderson
2017-05-10 20:32 ` Philippe Mathieu-Daudé
2017-05-12 1:31 ` Philippe Mathieu-Daudé
2017-05-10 20:05 ` [Qemu-devel] [PATCH 3/8] target/arm: optimize rev16() " Philippe Mathieu-Daudé
2017-05-12 1:54 ` Philippe Mathieu-Daudé
2017-05-10 20:05 ` [Qemu-devel] [PATCH 4/8] target/cris: optimize gen_swapb() " Philippe Mathieu-Daudé
2017-05-12 1:29 ` Philippe Mathieu-Daudé
2017-05-10 20:05 ` [Qemu-devel] [PATCH 5/8] target/m68k: optimize bcd_flags() " Philippe Mathieu-Daudé
2017-05-11 8:41 ` Laurent Vivier
2017-05-12 1:52 ` Philippe Mathieu-Daudé
2017-05-10 20:05 ` [Qemu-devel] [PATCH 6/8] target/mips: optimize bshfl() " Philippe Mathieu-Daudé
2017-05-12 2:13 ` Philippe Mathieu-Daudé
2017-05-10 20:05 ` [Qemu-devel] [PATCH 7/8] target/ppc: optimize various functions " Philippe Mathieu-Daudé
2017-05-11 0:41 ` David Gibson
2017-05-11 8:46 ` [Qemu-devel] [Qemu-ppc] " Laurent Vivier
2017-05-12 5:13 ` David Gibson [this message]
2017-05-11 4:54 ` [Qemu-devel] " Nikunj A Dadhania
2017-05-12 1:48 ` Philippe Mathieu-Daudé
2017-05-12 5:16 ` David Gibson
2017-05-10 20:05 ` [Qemu-devel] [PATCH 8/8] target/sparc: " Philippe Mathieu-Daudé
2017-05-12 1:50 ` Philippe Mathieu-Daudé
2017-05-10 20:20 ` [Qemu-devel] [PATCH 0/8] optimize various tcg_gen() " no-reply
2017-05-12 2:34 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170512051313.GB12908@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=f4bug@amsat.org \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).