From: Kamil Rytarowski <n54@gmx.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, claudio.fontana@huawei.com,
Kamil Rytarowski <n54@gmx.com>
Subject: [Qemu-devel] [PATCH] libvixl: Correct ordering of includes and fix NetBSD build
Date: Sat, 13 May 2017 03:54:49 +0200 [thread overview]
Message-ID: <20170513015449.24061-1-n54@gmx.com> (raw)
The __STDC_CONSTANT_MACROS symbol must be defined before including
directly or indirectly <stdint.h> in order to get support for macros
for integer constants like INT8_C().
The vixl/globals.h headers defines __STDC_CONSTANT_MACROS and must be
included before other system headers.
This change fixes build failures on NetBSD.
Signed-off-by: Kamil Rytarowski <n54@gmx.com>
---
disas/libvixl/vixl/a64/disasm-a64.cc | 2 +-
disas/libvixl/vixl/utils.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/disas/libvixl/vixl/a64/disasm-a64.cc b/disas/libvixl/vixl/a64/disasm-a64.cc
index 7a58a5c087..fc87306893 100644
--- a/disas/libvixl/vixl/a64/disasm-a64.cc
+++ b/disas/libvixl/vixl/a64/disasm-a64.cc
@@ -24,8 +24,8 @@
// OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-#include <cstdlib>
#include "vixl/a64/disasm-a64.h"
+#include <cstdlib>
namespace vixl {
diff --git a/disas/libvixl/vixl/utils.h b/disas/libvixl/vixl/utils.h
index 5ab134e240..17034addbc 100644
--- a/disas/libvixl/vixl/utils.h
+++ b/disas/libvixl/vixl/utils.h
@@ -27,10 +27,10 @@
#ifndef VIXL_UTILS_H
#define VIXL_UTILS_H
-#include <string.h>
-#include <cmath>
#include "vixl/globals.h"
#include "vixl/compiler-intrinsics.h"
+#include <string.h>
+#include <cmath>
namespace vixl {
--
2.12.2
next reply other threads:[~2017-05-13 2:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-13 1:54 Kamil Rytarowski [this message]
2017-05-13 22:04 ` [Qemu-devel] [PATCH] libvixl: Correct ordering of includes and fix NetBSD build Philippe Mathieu-Daudé
2017-05-13 22:15 ` Kamil Rytarowski
2017-05-15 13:57 ` Eric Blake
2017-05-15 13:57 ` Kamil Rytarowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170513015449.24061-1-n54@gmx.com \
--to=n54@gmx.com \
--cc=claudio.fontana@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).