From: jacob pan <jacob.jun.pan@intel.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: "Liu, Yi L" <yi.l.liu@intel.com>,
kvm@vger.kernel.org, iommu@lists.linux-foundation.org,
peterx@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org,
kevin.tian@intel.com, ashok.raj@intel.com, tianyu.lan@intel.com,
jean-philippe.brucker@arm.com,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
"Liu, Yi L" <yi.l.liu@linux.intel.com>,
jacob.jun.pan@intel.com
Subject: Re: [Qemu-devel] [RFC PATCH 2/8] iommu/vt-d: add bind_pasid_table function
Date: Mon, 15 May 2017 06:14:22 -0700 [thread overview]
Message-ID: <20170515061422.0000350b@intel.com> (raw)
In-Reply-To: <20170512155929.66809113@t450s.home>
On Fri, 12 May 2017 15:59:29 -0600
Alex Williamson <alex.williamson@redhat.com> wrote:
> > + if (pasidt_binfo->size >= intel_iommu_get_pts(iommu)) {
> > + pr_err("Invalid gPASID table size %llu, host size
> > %lu\n",
> > + pasidt_binfo->size,
> > + intel_iommu_get_pts(iommu));
> > + ret = -EINVAL;
> > + goto out;
>
> equal is not valid?
you are right, equal is valid. I was thinking of shared PASID space
between guest and host but that is not the case here.
The rest of your comments are taken too, thanks for the review.
Jacob
next prev parent reply other threads:[~2017-05-15 13:14 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 10:11 [Qemu-devel] [RFC PATCH 0/8] Shared Virtual Memory virtualization for VT-d Liu, Yi L
2017-04-26 10:11 ` [Qemu-devel] [RFC PATCH 1/8] iommu: Introduce bind_pasid_table API function Liu, Yi L
2017-04-26 16:56 ` Jean-Philippe Brucker
2017-04-26 18:29 ` jacob pan
2017-04-26 18:59 ` Jean-Philippe Brucker
2017-04-27 6:36 ` Liu, Yi L
2017-04-27 10:12 ` Jean-Philippe Brucker
2017-04-28 7:59 ` Liu, Yi L
2017-04-28 9:04 ` Liu, Yi L
2017-04-28 12:51 ` Jean-Philippe Brucker
2017-05-23 7:50 ` Liu, Yi L
2017-05-25 12:33 ` Jean-Philippe Brucker
2017-05-12 21:59 ` Alex Williamson
2017-05-14 10:56 ` Liu, Yi L
2017-04-26 10:11 ` [Qemu-devel] [RFC PATCH 2/8] iommu/vt-d: add bind_pasid_table function Liu, Yi L
2017-05-12 21:59 ` Alex Williamson
2017-05-15 13:14 ` jacob pan [this message]
2017-04-26 10:12 ` [Qemu-devel] [RFC PATCH 3/8] iommu: Introduce iommu do invalidate API function Liu, Yi L
2017-05-12 21:59 ` Alex Williamson
2017-05-17 10:23 ` Liu, Yi L
2017-04-26 10:12 ` [Qemu-devel] [RFC PATCH 4/8] iommu/vt-d: Add iommu do invalidate function Liu, Yi L
2017-05-12 21:59 ` Alex Williamson
2017-05-17 10:24 ` Liu, Yi L
2017-04-26 10:12 ` [Qemu-devel] [RFC PATCH 5/8] VFIO: Add new IOTCL for PASID Table bind propagation Liu, Yi L
2017-04-26 16:56 ` Jean-Philippe Brucker
2017-04-27 5:43 ` Liu, Yi L
2017-05-11 10:29 ` Liu, Yi L
2017-05-12 21:58 ` Alex Williamson
2017-05-17 10:27 ` Liu, Yi L
2017-05-18 11:29 ` Jean-Philippe Brucker
2017-04-26 10:12 ` [Qemu-devel] [RFC PATCH 6/8] VFIO: do pasid table binding Liu, Yi L
2017-05-09 7:55 ` Xiao Guangrong
2017-05-11 10:29 ` Liu, Yi L
2017-05-12 21:59 ` Alex Williamson
2017-04-26 10:12 ` [Qemu-devel] [RFC PATCH 7/8] VFIO: Add new IOCTL for IOMMU TLB invalidate propagation Liu, Yi L
2017-05-12 12:11 ` Jean-Philippe Brucker
2017-05-14 10:12 ` Liu, Yi L
2017-05-15 12:14 ` Jean-Philippe Brucker
2017-07-02 10:06 ` Liu, Yi L
2017-07-03 11:52 ` Jean-Philippe Brucker
2017-07-03 10:31 ` Liu, Yi L
2017-07-05 6:45 ` Tian, Kevin
2017-07-05 12:42 ` Jean-Philippe Brucker
2017-07-05 17:28 ` Alex Williamson
2017-07-05 22:26 ` Tian, Kevin
2017-07-14 8:58 ` Liu, Yi L
2017-07-14 18:15 ` Alex Williamson
2017-07-17 10:58 ` Liu, Yi L
2017-07-17 22:45 ` Alex Williamson
2017-07-18 9:38 ` Jean-Philippe Brucker
2017-07-18 14:29 ` Alex Williamson
2017-07-18 15:03 ` Jean-Philippe Brucker
2017-07-19 10:45 ` Liu, Yi L
2017-07-19 21:50 ` Jacob Pan
2017-07-05 22:31 ` Tian, Kevin
2017-05-12 21:58 ` Alex Williamson
2017-05-14 10:55 ` Liu, Yi L
2017-07-05 5:32 ` Tian, Kevin
2017-04-26 10:12 ` [Qemu-devel] [RFC PATCH 8/8] VFIO: do IOMMU TLB invalidation from guest Liu, Yi L
2017-05-08 4:09 ` [Qemu-devel] [RFC PATCH 0/8] Shared Virtual Memory virtualization for VT-d Xiao Guangrong
2017-05-07 7:33 ` Liu, Yi L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515061422.0000350b@intel.com \
--to=jacob.jun.pan@intel.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jasowang@redhat.com \
--cc=jean-philippe.brucker@arm.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tianyu.lan@intel.com \
--cc=yi.l.liu@intel.com \
--cc=yi.l.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).