From: Fam Zheng <famz@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
QEMU Trivial <qemu-trivial@nongnu.org>,
"open list:raw" <qemu-block@nongnu.org>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block/win32: fix 'ret not initialized' warning
Date: Tue, 16 May 2017 16:03:32 +0800 [thread overview]
Message-ID: <20170516080332.GA27669@lemon.lan> (raw)
In-Reply-To: <2c224267-32ec-ccf7-ae80-113ebfdce1e2@weilnetz.de>
On Tue, 05/16 09:52, Stefan Weil wrote:
> Am 16.05.2017 um 09:42 schrieb Gerd Hoffmann:
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> > block/file-win32.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/block/file-win32.c b/block/file-win32.c
> > index 1a35dbabf2..8f14f0bdcd 100644
> > --- a/block/file-win32.c
> > +++ b/block/file-win32.c
> > @@ -346,6 +346,7 @@ static int raw_open(BlockDriverState *bs, QDict *options, int flags,
> >
> > if (qdict_get_try_bool(options, "locking", false)) {
> > error_setg(errp, "locking=on is not supported on Windows");
> > + ret = -EINVAL;
> > goto fail;
> > }
>
>
> This is a bug fix for commit 1c3a555c.
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
>
Thank you!
Reviewed-by: Fam Zheng <famz@redhat.com>
next prev parent reply other threads:[~2017-05-16 8:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 7:42 [Qemu-devel] [PATCH] block/win32: fix 'ret not initialized' warning Gerd Hoffmann
2017-05-16 7:52 ` Stefan Weil
2017-05-16 8:03 ` Fam Zheng [this message]
2017-05-16 14:34 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516080332.GA27669@lemon.lan \
--to=famz@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).