qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH 4/5] target/sh4: ignore interrupts in a delay slot
Date: Wed, 17 May 2017 00:47:20 +0200	[thread overview]
Message-ID: <20170516224721.13832-5-aurelien@aurel32.net> (raw)
In-Reply-To: <20170516224721.13832-1-aurelien@aurel32.net>

Delay slots are indivisible, therefore avoid scheduling an interrupt in
the delay slot. However exceptions are possible.

Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
 target/sh4/helper.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/target/sh4/helper.c b/target/sh4/helper.c
index d420931530..19d4ec5fb5 100644
--- a/target/sh4/helper.c
+++ b/target/sh4/helper.c
@@ -871,8 +871,16 @@ int cpu_sh4_is_cached(CPUSH4State * env, target_ulong addr)
 bool superh_cpu_exec_interrupt(CPUState *cs, int interrupt_request)
 {
     if (interrupt_request & CPU_INTERRUPT_HARD) {
-        superh_cpu_do_interrupt(cs);
-        return true;
+        SuperHCPU *cpu = SUPERH_CPU(cs);
+        CPUSH4State *env = &cpu->env;
+
+        /* Delay slots are indivisible, ignore interrupts */
+        if (env->flags & DELAY_SLOT_MASK) {
+            return false;
+        } else {
+            superh_cpu_do_interrupt(cs);
+            return true;
+        }
     }
     return false;
 }
-- 
2.11.0

  parent reply	other threads:[~2017-05-16 22:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-16 22:47 [Qemu-devel] [PATCH 0/5] target/sh4: system emulation improvement Aurelien Jarno
2017-05-16 22:47 ` [Qemu-devel] [PATCH 1/5] target/sh4: log unauthorized accesses using qemu_log_mask Aurelien Jarno
2017-05-17  1:01   ` Philippe Mathieu-Daudé
2017-05-24 22:51   ` Richard Henderson
2017-05-16 22:47 ` [Qemu-devel] [PATCH 2/5] target/sh4: fix reset when using a kernel and an initrd Aurelien Jarno
2017-05-24 22:52   ` Richard Henderson
2017-05-16 22:47 ` [Qemu-devel] [PATCH 3/5] target/sh4: introduce DELAY_SLOT_MASK Aurelien Jarno
2017-05-17  1:04   ` Philippe Mathieu-Daudé
2017-05-24 22:52   ` Richard Henderson
2017-05-16 22:47 ` Aurelien Jarno [this message]
2017-05-17  1:05   ` [Qemu-devel] [PATCH 4/5] target/sh4: ignore interrupts in a delay slot Philippe Mathieu-Daudé
2017-05-24 22:52   ` Richard Henderson
2017-05-16 22:47 ` [Qemu-devel] [PATCH 5/5] target/sh4: fix RTE instruction " Aurelien Jarno
2017-05-24 23:11   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170516224721.13832-5-aurelien@aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).