* [Qemu-devel] [PATCH v2] ui: egl-headless requires dmabuf support
@ 2017-05-17 12:27 Gerd Hoffmann
2017-05-17 17:23 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2017-05-17 12:27 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann, Paolo Bonzini
Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
vl.c | 4 ++--
ui/Makefile.objs | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/vl.c b/vl.c
index 5c9b40eb1c..2d7aeec186 100644
--- a/vl.c
+++ b/vl.c
@@ -2129,7 +2129,7 @@ static DisplayType select_display(const char *p)
exit(1);
}
} else if (strstart(p, "egl-headless", &opts)) {
-#ifdef CONFIG_OPENGL
+#ifdef CONFIG_OPENGL_DMABUF
request_opengl = 1;
display_opengl = 1;
display = DT_EGL;
@@ -4668,7 +4668,7 @@ int main(int argc, char **argv, char **envp)
qemu_spice_display_init();
}
-#ifdef CONFIG_OPENGL
+#ifdef CONFIG_OPENGL_DMABUF
if (display_type == DT_EGL) {
egl_headless_init();
}
diff --git a/ui/Makefile.objs b/ui/Makefile.objs
index aac6ae8bef..3369451285 100644
--- a/ui/Makefile.objs
+++ b/ui/Makefile.objs
@@ -33,7 +33,7 @@ common-obj-y += shader.o
common-obj-y += console-gl.o
common-obj-y += egl-helpers.o
common-obj-y += egl-context.o
-common-obj-y += egl-headless.o
+common-obj-$(CONFIG_OPENGL_DMABUF) += egl-headless.o
ifeq ($(CONFIG_GTK_GL),y)
common-obj-$(CONFIG_GTK) += gtk-gl-area.o
else
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH v2] ui: egl-headless requires dmabuf support
2017-05-17 12:27 [Qemu-devel] [PATCH v2] ui: egl-headless requires dmabuf support Gerd Hoffmann
@ 2017-05-17 17:23 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-05-17 17:23 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel; +Cc: Paolo Bonzini
On 05/17/2017 09:27 AM, Gerd Hoffmann wrote:
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> vl.c | 4 ++--
> ui/Makefile.objs | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 5c9b40eb1c..2d7aeec186 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2129,7 +2129,7 @@ static DisplayType select_display(const char *p)
> exit(1);
> }
> } else if (strstart(p, "egl-headless", &opts)) {
> -#ifdef CONFIG_OPENGL
> +#ifdef CONFIG_OPENGL_DMABUF
> request_opengl = 1;
> display_opengl = 1;
> display = DT_EGL;
> @@ -4668,7 +4668,7 @@ int main(int argc, char **argv, char **envp)
> qemu_spice_display_init();
> }
>
> -#ifdef CONFIG_OPENGL
> +#ifdef CONFIG_OPENGL_DMABUF
> if (display_type == DT_EGL) {
> egl_headless_init();
> }
> diff --git a/ui/Makefile.objs b/ui/Makefile.objs
> index aac6ae8bef..3369451285 100644
> --- a/ui/Makefile.objs
> +++ b/ui/Makefile.objs
> @@ -33,7 +33,7 @@ common-obj-y += shader.o
> common-obj-y += console-gl.o
> common-obj-y += egl-helpers.o
> common-obj-y += egl-context.o
> -common-obj-y += egl-headless.o
> +common-obj-$(CONFIG_OPENGL_DMABUF) += egl-headless.o
> ifeq ($(CONFIG_GTK_GL),y)
> common-obj-$(CONFIG_GTK) += gtk-gl-area.o
> else
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-17 17:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-17 12:27 [Qemu-devel] [PATCH v2] ui: egl-headless requires dmabuf support Gerd Hoffmann
2017-05-17 17:23 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).