From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dAzCz-0005BQ-ID for qemu-devel@nongnu.org; Wed, 17 May 2017 09:41:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dAzCy-00042y-K0 for qemu-devel@nongnu.org; Wed, 17 May 2017 09:41:45 -0400 From: Eduardo Habkost Date: Wed, 17 May 2017 10:39:52 -0300 Message-Id: <20170517134003.17110-12-ehabkost@redhat.com> In-Reply-To: <20170517134003.17110-1-ehabkost@redhat.com> References: <20170517134003.17110-1-ehabkost@redhat.com> Subject: [Qemu-devel] [PULL 11/22] allwinner-ahci: Remove user_creatable flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Stefan Hajnoczi Cc: qemu-devel@nongnu.org, John Snow , qemu-block@nongnu.org, Beniamino Galvani , qemu-arm@nongnu.org, Marcel Apfelbaum allwinner-ahci needs its IRQ to be connected and mmio to be mapped (this is done by the alwinner-a10 device realize method), and won't work with -device. Remove the user_creatable flag from the device class. Cc: John Snow Cc: qemu-block@nongnu.org Cc: Beniamino Galvani Cc: Peter Maydell Cc: qemu-arm@nongnu.org Cc: Marcel Apfelbaum Acked-by: John Snow Acked-by: Marcel Apfelbaum Signed-off-by: Eduardo Habkost Message-Id: <20170503203604.31462-12-ehabkost@redhat.com> Signed-off-by: Eduardo Habkost --- hw/ide/ahci.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 2ea1a282ef..f60826d6e0 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -1815,11 +1815,6 @@ static void allwinner_ahci_class_init(ObjectClass *klass, void *data) DeviceClass *dc = DEVICE_CLASS(klass); dc->vmsd = &vmstate_allwinner_ahci; - /* - * FIXME: Set only because we are not sure yet if this device - * will be outside the q35 sysbus whitelist. - */ - dc->user_creatable = true; } static const TypeInfo allwinner_ahci_info = { -- 2.11.0.259.g40922b1