qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
	Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, Marcel Apfelbaum <marcel@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PULL 12/22] isabus-bridge: Remove user_creatable flag
Date: Wed, 17 May 2017 10:39:53 -0300	[thread overview]
Message-ID: <20170517134003.17110-13-ehabkost@redhat.com> (raw)
In-Reply-To: <20170517134003.17110-1-ehabkost@redhat.com>

isabus-bridge needs to be created by isa_bus_new(), and won't
work with -device, as it won't create the TYPE_ISA_BUS bus
itself. Remove the user_creatable flag from the device class.

Cc: Marcel Apfelbaum <marcel@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Acked-by: Marcel Apfelbaum <marcel@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20170503203604.31462-13-ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 hw/isa/isa-bus.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c
index ad4ac3b4f6..348e0eab9d 100644
--- a/hw/isa/isa-bus.c
+++ b/hw/isa/isa-bus.c
@@ -221,11 +221,6 @@ static void isabus_bridge_class_init(ObjectClass *klass, void *data)
 
     set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
     dc->fw_name = "isa";
-    /*
-     * FIXME: Set only because we are not sure yet if this device
-     * will be outside the q35 sysbus whitelist.
-     */
-    dc->user_creatable = true;
 }
 
 static const TypeInfo isabus_bridge_info = {
-- 
2.11.0.259.g40922b1

  parent reply	other threads:[~2017-05-17 13:41 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-17 13:39 [Qemu-devel] [PULL 00/22] x86 and machine queue, 2017-05-17 Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 01/22] qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 02/22] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 03/22] xen-backend: Remove FIXME comment about user_creatable flag Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 04/22] iommu: Remove FIXME comment about user_creatable=true Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 05/22] fdc: Remove user_creatable flag from sysbus-fdc & SUNW, fdtwo Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 06/22] pflash_cfi01: Remove user_creatable flag Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 07/22] kvmclock: " Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 08/22] ioapic: " Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 09/22] kvmvapic: " Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 10/22] sysbus-ahci: " Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 11/22] allwinner-ahci: " Eduardo Habkost
2017-05-17 13:39 ` Eduardo Habkost [this message]
2017-05-17 13:39 ` [Qemu-devel] [PULL 13/22] unimplemented-device: " Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 14/22] fw_cfg: " Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 15/22] esp: " Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 16/22] generic-sdhci: " Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 17/22] hpet: " Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 18/22] sysbus-ohci: " Eduardo Habkost
2017-05-17 13:40 ` [Qemu-devel] [PULL 19/22] virtio-mmio: " Eduardo Habkost
2017-05-17 13:40 ` [Qemu-devel] [PULL 20/22] xen-sysdev: " Eduardo Habkost
2017-05-17 13:40 ` [Qemu-devel] [PULL 21/22] s390-pcibus: No need to set user_creatable=false explicitly Eduardo Habkost
2017-05-17 13:40 ` [Qemu-devel] [PULL 22/22] tests: Add [+-]feature and feature=on|off test cases Eduardo Habkost
2017-05-17 15:43 ` [Qemu-devel] [PULL 00/22] x86 and machine queue, 2017-05-17 Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170517134003.17110-13-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).