From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dAzD7-0005IY-7n for qemu-devel@nongnu.org; Wed, 17 May 2017 09:41:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dAzD6-0004CL-Ar for qemu-devel@nongnu.org; Wed, 17 May 2017 09:41:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59254) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dAzD6-0004CB-4A for qemu-devel@nongnu.org; Wed, 17 May 2017 09:41:52 -0400 From: Eduardo Habkost Date: Wed, 17 May 2017 10:39:54 -0300 Message-Id: <20170517134003.17110-14-ehabkost@redhat.com> In-Reply-To: <20170517134003.17110-1-ehabkost@redhat.com> References: <20170517134003.17110-1-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 13/22] unimplemented-device: Remove user_creatable flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Marcel Apfelbaum , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= unimplemented-device needs to be created and mapped using create_unimplemented_device() (or equivalent code), and won't work with -device. Remove the user_creatable flag from the device class. Cc: Marcel Apfelbaum Cc: Peter Maydell Cc: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Marcel Apfelbaum Signed-off-by: Eduardo Habkost Message-Id: <20170503203604.31462-14-ehabkost@redhat.com> Signed-off-by: Eduardo Habkost --- hw/misc/unimp.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/misc/unimp.c b/hw/misc/unimp.c index e446c1d652..bcbb585888 100644 --- a/hw/misc/unimp.c +++ b/hw/misc/unimp.c @@ -90,11 +90,6 @@ static void unimp_class_init(ObjectClass *klass, void = *data) =20 dc->realize =3D unimp_realize; dc->props =3D unimp_properties; - /* - * FIXME: Set only because we are not sure yet if this device - * will be outside the q35 sysbus whitelist. - */ - dc->user_creatable =3D true; } =20 static const TypeInfo unimp_info =3D { --=20 2.11.0.259.g40922b1