From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59198) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dAzDU-0005oT-Ek for qemu-devel@nongnu.org; Wed, 17 May 2017 09:42:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dAzDO-0004IA-FX for qemu-devel@nongnu.org; Wed, 17 May 2017 09:42:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38310) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dAzDO-0004HS-9k for qemu-devel@nongnu.org; Wed, 17 May 2017 09:42:10 -0400 From: Eduardo Habkost Date: Wed, 17 May 2017 10:39:57 -0300 Message-Id: <20170517134003.17110-17-ehabkost@redhat.com> In-Reply-To: <20170517134003.17110-1-ehabkost@redhat.com> References: <20170517134003.17110-1-ehabkost@redhat.com> Subject: [Qemu-devel] [PULL 16/22] generic-sdhci: Remove user_creatable flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Stefan Hajnoczi Cc: qemu-devel@nongnu.org, "Edgar E. Iglesias" , David Gibson , Alexander Graf , "Michael S. Tsirkin" , Marcel Apfelbaum , Prasad J Pandit , Alistair Francis generic-sdhci needs to be wired by other devices' code, so it can't be used with -device. Remove the user_creatable flag from the device class. Cc: Peter Maydell Cc: "Edgar E. Iglesias" Cc: David Gibson Cc: Alexander Graf Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Cc: Prasad J Pandit Cc: Alistair Francis Reviewed-by: Alistair Francis Acked-by: Marcel Apfelbaum Signed-off-by: Eduardo Habkost Message-Id: <20170503203604.31462-17-ehabkost@redhat.com> Signed-off-by: Eduardo Habkost --- hw/sd/sdhci.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index dbf61fccb8..6d6a791ee9 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -1360,11 +1360,6 @@ static void sdhci_sysbus_class_init(ObjectClass *klass, void *data) dc->props = sdhci_sysbus_properties; dc->realize = sdhci_sysbus_realize; dc->reset = sdhci_poweron_reset; - /* - * FIXME: Set only because we are not sure yet if this device - * will be outside the q35 sysbus whitelist. - */ - dc->user_creatable = true; } static const TypeInfo sdhci_sysbus_info = { -- 2.11.0.259.g40922b1