From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, Marcel Apfelbaum <marcel@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PULL 04/22] iommu: Remove FIXME comment about user_creatable=true
Date: Wed, 17 May 2017 10:39:45 -0300 [thread overview]
Message-ID: <20170517134003.17110-5-ehabkost@redhat.com> (raw)
In-Reply-To: <20170517134003.17110-1-ehabkost@redhat.com>
amd-iommu and intel-iommu are really meant to be used with
-device, so they need user_creatable=true. Remove the FIXME
comment.
Cc: Marcel Apfelbaum <marcel@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Acked-by: Marcel Apfelbaum <marcel@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20170503203604.31462-5-ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
hw/i386/amd_iommu.c | 5 +----
hw/i386/intel_iommu.c | 5 +----
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
index 7b92c8c15a..efcc93cbfd 100644
--- a/hw/i386/amd_iommu.c
+++ b/hw/i386/amd_iommu.c
@@ -1186,10 +1186,7 @@ static void amdvi_class_init(ObjectClass *klass, void* data)
dc->vmsd = &vmstate_amdvi;
dc->hotpluggable = false;
dc_class->realize = amdvi_realize;
- /*
- * FIXME: Set only because we are not sure yet if this device
- * will be outside the q35 sysbus whitelist.
- */
+ /* Supported by the pc-q35-* machine types */
dc->user_creatable = true;
}
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index 54187a04a4..327a46cd19 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -3009,10 +3009,7 @@ static void vtd_class_init(ObjectClass *klass, void *data)
dc->hotpluggable = false;
x86_class->realize = vtd_realize;
x86_class->int_remap = vtd_int_remap;
- /*
- * FIXME: Set only because we are not sure yet if this device
- * will be outside the q35 sysbus whitelist.
- */
+ /* Supported by the pc-q35-* machine types */
dc->user_creatable = true;
}
--
2.11.0.259.g40922b1
next prev parent reply other threads:[~2017-05-17 13:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 13:39 [Qemu-devel] [PULL 00/22] x86 and machine queue, 2017-05-17 Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 01/22] qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 02/22] sysbus: Set user_creatable=false by default on TYPE_SYS_BUS_DEVICE Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 03/22] xen-backend: Remove FIXME comment about user_creatable flag Eduardo Habkost
2017-05-17 13:39 ` Eduardo Habkost [this message]
2017-05-17 13:39 ` [Qemu-devel] [PULL 05/22] fdc: Remove user_creatable flag from sysbus-fdc & SUNW, fdtwo Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 06/22] pflash_cfi01: Remove user_creatable flag Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 07/22] kvmclock: " Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 08/22] ioapic: " Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 09/22] kvmvapic: " Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 10/22] sysbus-ahci: " Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 11/22] allwinner-ahci: " Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 12/22] isabus-bridge: " Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 13/22] unimplemented-device: " Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 14/22] fw_cfg: " Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 15/22] esp: " Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 16/22] generic-sdhci: " Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 17/22] hpet: " Eduardo Habkost
2017-05-17 13:39 ` [Qemu-devel] [PULL 18/22] sysbus-ohci: " Eduardo Habkost
2017-05-17 13:40 ` [Qemu-devel] [PULL 19/22] virtio-mmio: " Eduardo Habkost
2017-05-17 13:40 ` [Qemu-devel] [PULL 20/22] xen-sysdev: " Eduardo Habkost
2017-05-17 13:40 ` [Qemu-devel] [PULL 21/22] s390-pcibus: No need to set user_creatable=false explicitly Eduardo Habkost
2017-05-17 13:40 ` [Qemu-devel] [PULL 22/22] tests: Add [+-]feature and feature=on|off test cases Eduardo Habkost
2017-05-17 15:43 ` [Qemu-devel] [PULL 00/22] x86 and machine queue, 2017-05-17 Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170517134003.17110-5-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).