From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com
Subject: Re: [Qemu-devel] [PATCH 5/9] migration: Move qjson.h to migration/
Date: Wed, 17 May 2017 17:05:04 +0100 [thread overview]
Message-ID: <20170517160504.GD2196@work-vm> (raw)
In-Reply-To: <20170517154756.22079-6-quintela@redhat.com>
* Juan Quintela (quintela@redhat.com) wrote:
> It is only used for migration code.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/qjson.c | 2 +-
> {include/migration => migration}/qjson.h | 0
> migration/vmstate.c | 2 +-
> 3 files changed, 2 insertions(+), 2 deletions(-)
> rename {include/migration => migration}/qjson.h (100%)
>
> diff --git a/migration/qjson.c b/migration/qjson.c
> index f345904..9d7f6eb 100644
> --- a/migration/qjson.c
> +++ b/migration/qjson.c
> @@ -25,7 +25,7 @@
>
> #include "qemu/osdep.h"
> #include "qapi/qmp/qstring.h"
> -#include "migration/qjson.h"
> +#include "qjson.h"
>
> struct QJSON {
> QString *str;
> diff --git a/include/migration/qjson.h b/migration/qjson.h
> similarity index 100%
> rename from include/migration/qjson.h
> rename to migration/qjson.h
> diff --git a/migration/vmstate.c b/migration/vmstate.c
> index 7b4a607..66c50ee 100644
> --- a/migration/vmstate.c
> +++ b/migration/vmstate.c
> @@ -7,7 +7,7 @@
> #include "qemu/error-report.h"
> #include "qemu/queue.h"
> #include "trace.h"
> -#include "migration/qjson.h"
> +#include "qjson.h"
>
> static void vmstate_subsection_save(QEMUFile *f, const VMStateDescription *vmsd,
> void *opaque, QJSON *vmdesc);
> --
> 2.9.3
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2017-05-17 16:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 15:47 [Qemu-devel] [PATCH v4 0/9] Migration mini-cleanup Juan Quintela
2017-05-17 15:47 ` [Qemu-devel] [PATCH 1/9] migration: Create migration/xbzrle.h Juan Quintela
2017-05-18 11:58 ` Peter Xu
2017-05-17 15:47 ` [Qemu-devel] [PATCH 2/9] migration: Split migration/channel.c for channel operations Juan Quintela
2017-05-18 11:59 ` Peter Xu
2017-05-17 15:47 ` [Qemu-devel] [PATCH 3/9] migration: Export qemu-file-channel.c functions in its own file Juan Quintela
2017-05-18 12:07 ` Peter Xu
2017-05-18 13:26 ` Juan Quintela
2017-05-19 2:46 ` Peter Xu
2017-05-23 11:28 ` Juan Quintela
2017-05-18 15:44 ` Dr. David Alan Gilbert
2017-05-18 15:48 ` Daniel P. Berrange
2017-05-18 16:08 ` Juan Quintela
2017-05-17 15:47 ` [Qemu-devel] [PATCH 4/9] migration: Remove migration.h from colo.h Juan Quintela
2017-05-18 12:07 ` Peter Xu
2017-05-17 15:47 ` [Qemu-devel] [PATCH 5/9] migration: Move qjson.h to migration/ Juan Quintela
2017-05-17 16:05 ` Dr. David Alan Gilbert [this message]
2017-05-17 15:47 ` [Qemu-devel] [PATCH 6/9] migration: Split vmstate-types.c from vmstate.c Juan Quintela
2017-05-18 12:10 ` Peter Xu
2017-05-17 15:47 ` [Qemu-devel] [PATCH 7/9] migration: Remove qemu-file.h from vmstate.h Juan Quintela
2017-05-17 15:47 ` [Qemu-devel] [PATCH 8/9] migration: Remove vmstate.h from migration.h Juan Quintela
2017-05-17 15:47 ` [Qemu-devel] [PATCH 9/9] migration: migration.h was not needed Juan Quintela
2017-05-17 16:04 ` Dr. David Alan Gilbert
2017-05-17 16:05 ` Dr. David Alan Gilbert
2017-05-18 12:10 ` Peter Xu
-- strict thread matches above, loose matches on Subject: below --
2017-05-18 16:16 [Qemu-devel] [PATCH v5 0/9] Migration mini-cleanup Juan Quintela
2017-05-18 16:16 ` [Qemu-devel] [PATCH 5/9] migration: Move qjson.h to migration/ Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170517160504.GD2196@work-vm \
--to=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).