From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Daniel P. Berrange" <berrange@redhat.com>
Subject: [Qemu-devel] [PATCH v2 0/5] Fix handling of IPv4/IPv6 dual stack
Date: Fri, 19 May 2017 19:03:37 +0100 [thread overview]
Message-ID: <20170519180342.19618-1-berrange@redhat.com> (raw)
This is a (much larger) followup to:
v1: https://lists.nongnu.org/archive/html/qemu-devel/2017-04/msg05659.html
This series aims to fix a lot of bugs related to handling of IPv4 / IPv6
dual stack.
- The VNC server mistakenly listened on two separate ports 5900+5901
when the to= parameter was given
- IPv6 sockets are accepting IPv4 clients even when IPv4 is set to
be disabled
- IPv6 sockets are failing to accept IPv4 clients when IPv4 is not set
to be disabled
- The VNC server was loosing the ipv4=/ipv6= settings due to a bug
in the DNS resolver
The behaviour of all this is really subtle and hard to get working correctly
across all the different network backends. Thus, the most important part of
this patch series is the last patch which adds a test case covering the
backends for -vnc, -chardev tcp, -net socket, and -incoming socket, with
a 120 entry matrix.
IOW, if you think any of the first 4 patches are applying the wrong logic,
then take a look at the last patch and indicate which test matrix entries
are believed to be defining wrong behaviour :-)
Daniel P. Berrange (5):
sockets: ensure we can bind to both ipv4 & ipv6 separately
sockets: don't block IPv4 clients when listening on "::"
sockets: ensure we don't accept IPv4 clients when IPv4 is disabled
io: preserve ipv4/ipv6 flags when resolving InetSocketAddress
tests: add functional test validating ipv4/ipv6 address flag handling
io/dns-resolver.c | 6 +-
tests/.gitignore | 1 +
tests/Makefile.include | 4 +
tests/test-sockets-proto.c | 855 +++++++++++++++++++++++++++++++++++++++++++++
util/qemu-sockets.c | 71 +++-
5 files changed, 916 insertions(+), 21 deletions(-)
create mode 100644 tests/test-sockets-proto.c
--
2.9.3
next reply other threads:[~2017-05-19 18:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 18:03 Daniel P. Berrange [this message]
2017-05-19 18:03 ` [Qemu-devel] [PATCH v2 1/5] sockets: ensure we can bind to both ipv4 & ipv6 separately Daniel P. Berrange
2017-05-19 23:27 ` Philippe Mathieu-Daudé
2017-05-22 15:26 ` Eric Blake
2017-05-22 15:33 ` Daniel P. Berrange
2017-05-19 18:03 ` [Qemu-devel] [PATCH v2 2/5] sockets: don't block IPv4 clients when listening on "::" Daniel P. Berrange
2017-05-19 23:49 ` Philippe Mathieu-Daudé
2017-05-22 15:30 ` Eric Blake
2017-05-22 15:34 ` Daniel P. Berrange
2017-05-19 18:03 ` [Qemu-devel] [PATCH v2 3/5] sockets: ensure we don't accept IPv4 clients when IPv4 is disabled Daniel P. Berrange
2017-05-22 15:32 ` Eric Blake
2017-05-19 18:03 ` [Qemu-devel] [PATCH v2 4/5] io: preserve ipv4/ipv6 flags when resolving InetSocketAddress Daniel P. Berrange
2017-05-19 23:53 ` Philippe Mathieu-Daudé
2017-05-22 15:33 ` Eric Blake
2017-05-19 18:03 ` [Qemu-devel] [PATCH v2 5/5] tests: add functional test validating ipv4/ipv6 address flag handling Daniel P. Berrange
2017-05-22 16:00 ` Eric Blake
2017-05-22 16:56 ` Daniel P. Berrange
2017-05-22 17:30 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170519180342.19618-1-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).