From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42214) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCz5E-0005au-9p for qemu-devel@nongnu.org; Mon, 22 May 2017 21:58:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCz5D-0004iM-Dt for qemu-devel@nongnu.org; Mon, 22 May 2017 21:58:00 -0400 Date: Mon, 22 May 2017 21:57:47 -0400 From: Jeff Cody Message-ID: <20170523015747.GG6761@localhost.localdomain> References: <20170508141310.8674-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170508141310.8674-1-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 00/11] Preparation for block job mutex List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, jsnow@redhat.com, stefanha@redhat.com On Mon, May 08, 2017 at 04:12:59PM +0200, Paolo Bonzini wrote: > These are a bunch of cleanups and patches extracted from the AioContext > lock removal series. As a general theme, the patches reorganize > blockjob.c to follow the blockjob.h/blockjob_int.h separation more > closely. For this reason, a lot of the patches are just moving functions > around. > > The blockjob.h/blockjob_int.h split later will correspond to different > locking rules, but the patches are independent from this change, and > can be applied/reviewed separately. > > There is no code change from v1, but all patches now have Reviewed-by > from at least one of John and Stefan. > > Thanks, > > Paolo > > > Paolo Bonzini (11): > blockjob: remove unnecessary check > blockjob: remove iostatus_reset callback > blockjob: introduce block_job_early_fail > blockjob: introduce block_job_pause/resume_all > blockjob: separate monitor and blockjob APIs > blockjob: move iostatus reset inside block_job_user_resume > blockjob: introduce block_job_cancel_async, check iostatus invariants > blockjob: group BlockJob transaction functions together > blockjob: strengthen a bit test-blockjob-txn > blockjob: reorganize block_job_completed_txn_abort > blockjob: use deferred_to_main_loop to indicate the coroutine has > ended > > block/backup.c | 2 +- > block/commit.c | 2 +- > block/io.c | 19 +- > block/mirror.c | 2 +- > blockdev.c | 1 - > blockjob.c | 900 +++++++++++++++++++++++-------------------- > include/block/blockjob.h | 16 - > include/block/blockjob_int.h | 27 +- > tests/test-blockjob-txn.c | 7 +- > tests/test-blockjob.c | 10 +- > 10 files changed, 522 insertions(+), 464 deletions(-) > > -- > 2.12.2 > Thanks, Applied to my block branch: git://github.com/codyprime/qemu-kvm-jtc block -Jeff