From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDBys-0000tL-I8 for qemu-devel@nongnu.org; Tue, 23 May 2017 11:44:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDByr-0002Z5-Ij for qemu-devel@nongnu.org; Tue, 23 May 2017 11:44:18 -0400 Date: Tue, 23 May 2017 17:44:03 +0200 From: Igor Mammedov Message-ID: <20170523174403.26a69d7c@Igors-MacBook-Pro.local> In-Reply-To: <20170523144854.GF32274@thinpad.lan.raisama.net> References: <1495550330-34087-1-git-send-email-imammedo@redhat.com> <1495550330-34087-5-git-send-email-imammedo@redhat.com> <20170523144854.GF32274@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 4/5] numa: fallback to default NUMA node instead of node 0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, David Gibson , Andrew Jones On Tue, 23 May 2017 11:48:54 -0300 Eduardo Habkost wrote: > On Tue, May 23, 2017 at 04:38:49PM +0200, Igor Mammedov wrote: > > Do the same as we did in commit > > (57924bcd8 numa: introduce machine callback for VCPU to node mapping) > > but only for incomplete mapping usecase, falling back to board > > provided default cpu to node mapping if user hasn't provided > > mapping for CPU explicitly. > > > > Signed-off-by: Igor Mammedov > > This breaks migration compatibility, doesn't it? I understand > this use case is not supported, but if are going to break stuff > for people using incomplete mappings (by rejecting the > configuration on a future release), I would prefer to break it > only once. it's firmware change and we generally don't care nor maintain firmware compat stuff the same as with above mentioned (57924bcd8 numa: introduce machine callback for VCPU to node mapping) > > > --- > > hw/core/machine.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/hw/core/machine.c b/hw/core/machine.c > > index 964b75d..b8df15f 100644 > > --- a/hw/core/machine.c > > +++ b/hw/core/machine.c > > @@ -730,9 +730,6 @@ static void machine_numa_finish_init(MachineState *machine) > > g_string_append_printf(s, "%sCPU %d [%s]", > > s->len ? ", " : "", i, cpu_str); > > g_free(cpu_str); > > - > > - /* non mapped cpus used to fallback to node 0 */ > > - props.node_id = 0; > > } > > > > props.has_node_id = true; > > -- > > 2.7.4 > > >