From: Fam Zheng <famz@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 06/16] backup: Request BLK_PERM_AIO_CONTEXT_CHANGE on target
Date: Wed, 24 May 2017 10:18:44 +0800 [thread overview]
Message-ID: <20170524021844.GG12279@lemon.lan> (raw)
In-Reply-To: <20170511194100.GI24584@stefanha-x1.localdomain>
On Thu, 05/11 15:41, Stefan Hajnoczi wrote:
> On Wed, Apr 19, 2017 at 05:43:46PM +0800, Fam Zheng wrote:
> > What's done in the source's context change notifier is moving the
> > target's context to follow the new one, so we request this permission
> > here.
>
> It's true that the backup block job must be able to set target's
> AioContext, but does this change also allow other users to set target's
> AioContext while the backup job is running? If yes, then we need to
> handle that.
If through job->target, yes, but I don't think there is any user of job->target.
Otherwise, it's not allowed, because the second parameter of blk_new doesn't
have BLK_PERM_AIO_CONTEXT_CHANGE.
So it's okay.
Fam
next prev parent reply other threads:[~2017-05-24 2:18 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 9:43 [Qemu-devel] [PATCH v2 00/16] block: Protect AIO context change with perm API Fam Zheng
2017-04-19 9:43 ` [Qemu-devel] [PATCH v2 01/16] block: Define BLK_PERM_AIO_CONTEXT_CHANGE Fam Zheng
2017-05-11 19:26 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-19 9:43 ` [Qemu-devel] [PATCH v2 02/16] block-backend: Add blk_request_perm Fam Zheng
2017-05-11 19:32 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-05-24 2:16 ` Fam Zheng
2017-04-19 9:43 ` [Qemu-devel] [PATCH v2 03/16] blockjob: Add BLK_PERM_AIO_CONTEXT_CHANGE shared perm on bs Fam Zheng
2017-05-11 19:33 ` Stefan Hajnoczi
2017-04-19 9:43 ` [Qemu-devel] [PATCH v2 04/16] blockjob: Allow aio context change on intermediate nodes Fam Zheng
2017-05-11 19:34 ` Stefan Hajnoczi
2017-04-19 9:43 ` [Qemu-devel] [PATCH v2 05/16] block: Propagate BLK_PERM_AIO_CONTEXT_CHANGE down the graph Fam Zheng
2017-05-11 19:35 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-19 9:43 ` [Qemu-devel] [PATCH v2 06/16] backup: Request BLK_PERM_AIO_CONTEXT_CHANGE on target Fam Zheng
2017-05-11 19:41 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-05-24 2:18 ` Fam Zheng [this message]
2017-05-31 9:39 ` Stefan Hajnoczi
2017-05-31 9:57 ` Fam Zheng
2017-06-01 13:26 ` Stefan Hajnoczi
2017-06-05 8:34 ` Fam Zheng
2017-04-19 9:43 ` [Qemu-devel] [PATCH v2 07/16] backup: Do initial aio context move of target via BB interface Fam Zheng
2017-05-11 20:00 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-19 9:43 ` [Qemu-devel] [PATCH v2 08/16] mirror: Request aio context change permission on target Fam Zheng
2017-05-11 20:01 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-19 9:43 ` [Qemu-devel] [PATCH v2 09/16] commit: Allow aio context change on s->base Fam Zheng
2017-05-11 20:06 ` Stefan Hajnoczi
2017-04-19 9:43 ` [Qemu-devel] [PATCH v2 10/16] mirror: Do initial aio context move of target via BB interface Fam Zheng
2017-05-11 20:27 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-05-24 2:23 ` Fam Zheng
2017-04-19 9:43 ` [Qemu-devel] [PATCH v2 11/16] virtio-scsi: Request BLK_PERM_AIO_CONTEXT_CHANGE for dataplane Fam Zheng
2017-05-11 20:28 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-19 9:43 ` [Qemu-devel] [PATCH v2 12/16] virtio-blk: " Fam Zheng
2017-05-11 20:29 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-19 9:43 ` [Qemu-devel] [PATCH v2 13/16] blk: fix aio context loss on media change Fam Zheng
2017-05-11 20:31 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-19 9:43 ` [Qemu-devel] [PATCH v2 14/16] nbd: Allow BLK_PERM_AIO_CONTEXT_CHANGE on BB Fam Zheng
2017-05-11 20:32 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-19 9:43 ` [Qemu-devel] [PATCH v2 15/16] block: Add perm assertion on blk_set_aio_context Fam Zheng
2017-05-11 20:33 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-19 9:43 ` [Qemu-devel] [PATCH v2 16/16] tests: Add test case for BLK_PERM_AIO_CONTEXT_CHANGE Fam Zheng
2017-05-11 20:36 ` Stefan Hajnoczi
2017-05-11 20:43 ` [Qemu-devel] [Qemu-block] [PATCH v2 00/16] block: Protect AIO context change with perm API Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524021844.GG12279@lemon.lan \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).