From: Peter Xu <peterx@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, lvivier@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/3] Remove of loadvm handlers
Date: Wed, 24 May 2017 17:41:01 +0800 [thread overview]
Message-ID: <20170524094101.GI3873@pxdev.xzpeter.org> (raw)
In-Reply-To: <20170524085519.22856-1-quintela@redhat.com>
On Wed, May 24, 2017 at 10:55:16AM +0200, Juan Quintela wrote:
> Hi
>
> We just have a loadvm handlers that are a new list only used in a
> single place. Just move everything to use the savevm_handlers (yes,
> it is a list, and we could have a better name).
>
> Once there, vmstate_load() had three arguments but only needs two. Fix that.
>
> Please, review.
>
> Juan Quintela (3):
> migration: Use savevm_handlers instead of loadvm copy
> migration: loadvm handlers are not used
> migration: Remove section_id parameter from vmstate_load
>
> include/migration/migration.h | 5 ----
> include/migration/vmstate.h | 2 --
> include/qemu/typedefs.h | 1 -
> migration/migration.c | 2 --
> migration/savevm.c | 58 ++++++++++++-------------------------------
> 5 files changed, 16 insertions(+), 52 deletions(-)
>
> --
> 2.9.3
>
This series looks nice to me. :-)
Series:
Reviewed-by: Peter Xu <peterx@redhat.com>
Thanks,
--
Peter Xu
prev parent reply other threads:[~2017-05-24 9:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 8:55 [Qemu-devel] [PATCH 0/3] Remove of loadvm handlers Juan Quintela
2017-05-24 8:55 ` [Qemu-devel] [PATCH 1/3] migration: Use savevm_handlers instead of loadvm copy Juan Quintela
2017-05-24 13:32 ` Laurent Vivier
2017-05-24 14:35 ` Juan Quintela
2017-05-24 8:55 ` [Qemu-devel] [PATCH 2/3] migration: loadvm handlers are not used Juan Quintela
2017-05-24 8:55 ` [Qemu-devel] [PATCH 3/3] migration: Remove section_id parameter from vmstate_load Juan Quintela
2017-05-24 9:41 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524094101.GI3873@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).