From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dDeOs-0006JO-96 for qemu-devel@nongnu.org; Wed, 24 May 2017 18:05:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dDeOp-0001dB-5B for qemu-devel@nongnu.org; Wed, 24 May 2017 18:05:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57050) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dDeOo-0001bX-Rl for qemu-devel@nongnu.org; Wed, 24 May 2017 18:04:59 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0ED9361BB0 for ; Wed, 24 May 2017 22:04:57 +0000 (UTC) Date: Thu, 25 May 2017 01:04:55 +0300 From: "Michael S. Tsirkin" Message-ID: <20170525010425-mutt-send-email-mst@kernel.org> References: <20170524080914.23484-1-lprosek@redhat.com> <437f8abb-8d19-f4cd-b92d-9780efa0fe0e@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] pc: ACPI BIOS: use highest NUMA node for hotplug mem hole SRAT entry List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ladi Prosek Cc: Laszlo Ersek , qemu-devel , Igor Mammedov On Wed, May 24, 2017 at 11:16:14AM +0200, Ladi Prosek wrote: > On Wed, May 24, 2017 at 11:07 AM, Laszlo Ersek wrote: > > On 05/24/17 10:09, Ladi Prosek wrote: > >> For reasons unknown, Windows won't online all memory, both at command > >> line and hot-plugged later, unless the hotplug mem hole SRAT entry > >> specifies a node greater or equal to the ones where memory is added. > > > > s/greater or equal to/greater *than* or equal to/ > > > > Thanks, > > Laszlo > > (always finding the important issues! ;) ) > > Haha, thanks! Igor, please let me know if you'd like me to send a > corrected version. Yes and pls include Igor's note to maintainer after --- so I don't forget. > >> > >> Using the highest node on the machine makes recent versions of Windows > >> happy. > >> > >> With this example command line: > >> ... \ > >> -m 1024,slots=4,maxmem=32G \ > >> -numa node,nodeid=0 \ > >> -numa node,nodeid=1 \ > >> -numa node,nodeid=2 \ > >> -numa node,nodeid=3 \ > >> -object memory-backend-ram,size=1G,id=mem-mem1 \ > >> -device pc-dimm,id=dimm-mem1,memdev=mem-mem1,node=1 > >> > >> Windows reports a total of 1G of RAM without this commit and the expected > >> 2G with this commit. > >> > >> Signed-off-by: Ladi Prosek > >> --- > >> hw/i386/acpi-build.c | 7 +++++-- > >> 1 file changed, 5 insertions(+), 2 deletions(-) > >> > >> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > >> index afcadac..9653583 100644 > >> --- a/hw/i386/acpi-build.c > >> +++ b/hw/i386/acpi-build.c > >> @@ -2404,14 +2404,17 @@ build_srat(GArray *table_data, BIOSLinker *linker, MachineState *machine) > >> } > >> > >> /* > >> - * Entry is required for Windows to enable memory hotplug in OS. > >> + * Entry is required for Windows to enable memory hotplug in OS > >> + * and for Linux to enable SWIOTLB even if booted with less than > >> + * 4G of RAM. Windows works better if the entry sets proximity > >> + * to the highest NUMA node in the machine. > >> * Memory devices may override proximity set by this entry, > >> * providing _PXM method if necessary. > >> */ > >> if (hotplugabble_address_space_size) { > >> numamem = acpi_data_push(table_data, sizeof *numamem); > >> build_srat_memory(numamem, pcms->hotplug_memory.base, > >> - hotplugabble_address_space_size, 0, > >> + hotplugabble_address_space_size, pcms->numa_nodes - 1, > >> MEM_AFFINITY_HOTPLUGGABLE | MEM_AFFINITY_ENABLED); > >> } > >> > >> > >