From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: eblake@redhat.com, armbru@redhat.com, mreitz@redhat.com,
kwolf@redhat.com, vsementsov@virtuozzo.com, den@openvz.org
Subject: [Qemu-devel] [PATCH 2/7] block: add bdrv_get_format_allocated_size format interface
Date: Thu, 25 May 2017 18:26:23 +0300 [thread overview]
Message-ID: <20170525152628.37628-3-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20170525152628.37628-1-vsementsov@virtuozzo.com>
The function should return actually used by top-level format driver
space (in it's .file). It differs from bdrv_get_allocated_file_size,
which returns allocated on fs file size.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
block.c | 15 +++++++++++++++
include/block/block.h | 1 +
include/block/block_int.h | 1 +
3 files changed, 17 insertions(+)
diff --git a/block.c b/block.c
index ba22fc0dfb..6e1a435490 100644
--- a/block.c
+++ b/block.c
@@ -3407,6 +3407,21 @@ int64_t bdrv_get_allocated_file_size(BlockDriverState *bs)
}
/**
+ * Actually used by top-level format driver space (in it's .file) in bytes
+ */
+int64_t bdrv_get_format_allocated_size(BlockDriverState *bs)
+{
+ BlockDriver *drv = bs->drv;
+ if (!drv) {
+ return -ENOMEDIUM;
+ }
+ if (drv->bdrv_get_format_allocated_size) {
+ return drv->bdrv_get_format_allocated_size(bs);
+ }
+ return -ENOTSUP;
+}
+
+/**
* Return number of sectors on success, -errno on error.
*/
int64_t bdrv_nb_sectors(BlockDriverState *bs)
diff --git a/include/block/block.h b/include/block/block.h
index 9b355e92d8..c36b9ccae4 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -304,6 +304,7 @@ int bdrv_truncate(BdrvChild *child, int64_t offset, Error **errp);
int64_t bdrv_nb_sectors(BlockDriverState *bs);
int64_t bdrv_getlength(BlockDriverState *bs);
int64_t bdrv_get_allocated_file_size(BlockDriverState *bs);
+int64_t bdrv_get_format_allocated_size(BlockDriverState *bs);
void bdrv_get_geometry(BlockDriverState *bs, uint64_t *nb_sectors_ptr);
void bdrv_refresh_limits(BlockDriverState *bs, Error **errp);
int bdrv_commit(BlockDriverState *bs);
diff --git a/include/block/block_int.h b/include/block/block_int.h
index 8d3724cce6..e562fa7a5a 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -208,6 +208,7 @@ struct BlockDriver {
int64_t (*bdrv_getlength)(BlockDriverState *bs);
bool has_variable_length;
int64_t (*bdrv_get_allocated_file_size)(BlockDriverState *bs);
+ int64_t (*bdrv_get_format_allocated_size)(BlockDriverState *bs);
int coroutine_fn (*bdrv_co_pwritev_compressed)(BlockDriverState *bs,
uint64_t offset, uint64_t bytes, QEMUIOVector *qiov);
--
2.11.1
next prev parent reply other threads:[~2017-05-25 15:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 15:26 [Qemu-devel] [PATCH 0/7] qemu-img check: unallocated size Vladimir Sementsov-Ogievskiy
2017-05-25 15:26 ` [Qemu-devel] [PATCH 1/7] block: fix comment for bdrv_get_allocated_file_size() Vladimir Sementsov-Ogievskiy
2017-05-25 16:32 ` Eric Blake
2017-05-25 16:34 ` Eric Blake
2017-05-25 17:03 ` Vladimir Sementsov-Ogievskiy
2017-05-25 17:46 ` Eric Blake
2017-05-25 17:56 ` Vladimir Sementsov-Ogievskiy
2017-05-25 15:26 ` Vladimir Sementsov-Ogievskiy [this message]
2017-05-25 17:54 ` [Qemu-devel] [PATCH 2/7] block: add bdrv_get_format_allocated_size format interface Eric Blake
2017-05-25 18:07 ` Vladimir Sementsov-Ogievskiy
2017-05-25 18:19 ` Vladimir Sementsov-Ogievskiy
2017-05-25 19:02 ` Eric Blake
2017-05-25 15:26 ` [Qemu-devel] [PATCH 3/7] qcow2: add .bdrv_get_format_allocated_size Vladimir Sementsov-Ogievskiy
2017-05-25 15:26 ` [Qemu-devel] [PATCH 4/7] common: make get_human_readable_size public Vladimir Sementsov-Ogievskiy
2017-05-25 17:57 ` Eric Blake
2017-05-25 15:26 ` [Qemu-devel] [PATCH 5/7] qemu-img check: add format unallocated size Vladimir Sementsov-Ogievskiy
2017-05-25 17:59 ` Eric Blake
2017-05-25 15:26 ` [Qemu-devel] [PATCH 6/7] qemu-img check: add file-size Vladimir Sementsov-Ogievskiy
2017-05-25 17:59 ` Eric Blake
2017-05-25 15:26 ` [Qemu-devel] [PATCH 7/7] block: rename _get_allocated_file_size() to _get_fs_allocated_size() Vladimir Sementsov-Ogievskiy
2017-05-25 15:34 ` Vladimir Sementsov-Ogievskiy
2017-05-25 18:01 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525152628.37628-3-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).