From: Kevin Wolf <kwolf@redhat.com>
To: Anton Nefedov <anton.nefedov@virtuozzo.com>
Cc: Alberto Garcia <berto@igalia.com>, Eric Blake <eblake@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
"Denis V . Lunev" <den@openvz.org>
Subject: Re: [Qemu-devel] [PATCH 0/7] qcow2: Reduce the number of I/O ops when doing COW
Date: Fri, 26 May 2017 12:17:27 +0200 [thread overview]
Message-ID: <20170526101727.GF7211@noname.str.redhat.com> (raw)
In-Reply-To: <0e3fc298-d47b-4066-c8c8-02f620c50b89@virtuozzo.com>
Am 24.05.2017 um 18:09 hat Anton Nefedov geschrieben:
> I agree; as mentioned we have similar patches and they don't conflict much.
> We noticed a performance regression on HDD though, for the
> presumably optimized case (random 4k write over a large backed
> image); so the patches were put on hold.
You're talking about your own patches that should do the same thing,
right? Can you re-do the same test with Berto's patches? Maybe there was
just an implementation glitch in yours.
This approach should very obviously result in a performance improvement,
and the patches are relatively simple, so I'm very much inclined to
merge this as soon as possible.
Kevin
next prev parent reply other threads:[~2017-05-26 10:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 11:22 [Qemu-devel] [PATCH 0/7] qcow2: Reduce the number of I/O ops when doing COW Alberto Garcia
2017-05-23 11:22 ` [Qemu-devel] [PATCH 1/7] qcow2: Remove unused Error in do_perform_cow() Alberto Garcia
2017-05-23 20:21 ` Eric Blake
2017-05-24 9:48 ` Alberto Garcia
2017-05-23 11:22 ` [Qemu-devel] [PATCH 2/7] qcow2: Use unsigned int for both members of Qcow2COWRegion Alberto Garcia
2017-05-23 11:22 ` [Qemu-devel] [PATCH 3/7] qcow2: Make perform_cow() call do_perform_cow() twice Alberto Garcia
2017-05-26 8:11 ` Kevin Wolf
2017-05-26 9:10 ` Alberto Garcia
2017-05-26 10:08 ` Kevin Wolf
2017-05-23 11:22 ` [Qemu-devel] [PATCH 4/7] qcow2: Split do_perform_cow() into _read(), _encrypt() and _write() Alberto Garcia
2017-05-23 11:23 ` [Qemu-devel] [PATCH 5/7] qcow2: Allow reading both COW regions with only one request Alberto Garcia
2017-05-23 11:23 ` [Qemu-devel] [PATCH 6/7] qcow2: Pass a QEMUIOVector to do_perform_cow_{read, write}() Alberto Garcia
2017-05-23 11:23 ` [Qemu-devel] [PATCH 7/7] qcow2: Merge the writing of the COW regions with the guest data Alberto Garcia
[not found] ` <5925B107.1060404@virtuozzo.com>
2017-05-24 16:43 ` Anton Nefedov
2017-05-24 19:05 ` Alberto Garcia
2017-05-26 10:12 ` Kevin Wolf
2017-05-26 14:09 ` Alberto Garcia
2017-05-23 14:36 ` [Qemu-devel] [PATCH 0/7] qcow2: Reduce the number of I/O ops when doing COW Eric Blake
2017-05-24 14:20 ` Alberto Garcia
2017-05-24 16:09 ` Anton Nefedov
2017-05-24 16:20 ` Alberto Garcia
2017-05-24 16:26 ` Anton Nefedov
2017-05-25 11:48 ` Alberto Garcia
2017-05-25 14:35 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2017-05-26 10:17 ` Kevin Wolf [this message]
2017-05-26 12:47 ` [Qemu-devel] " Anton Nefedov
2017-05-26 13:08 ` Alberto Garcia
2017-05-26 13:32 ` Anton Nefedov
2017-05-26 13:38 ` Alberto Garcia
2017-06-07 11:44 ` Alberto Garcia
2017-06-07 11:59 ` Kevin Wolf
2017-06-07 12:13 ` Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170526101727.GF7211@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=anton.nefedov@virtuozzo.com \
--cc=berto@igalia.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).