From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 1/9] ehci: fix overflow in frame timer code
Date: Mon, 29 May 2017 15:09:48 +0200 [thread overview]
Message-ID: <20170529130956.20297-2-kraxel@redhat.com> (raw)
In-Reply-To: <20170529130956.20297-1-kraxel@redhat.com>
In case the frame timer doesn't run for a while due to the host being
busy skipped_uframes can become big enough that UFRAME_TIMER_NS *
skipped_uframes overflows. Which in turn throws off all subsequent
ehci frame timer calculations.
Reported-by: 李林 <8610_28@163.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20170515104543.32044-1-kraxel@redhat.com
---
hw/usb/hcd-ehci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index 50ef817f93..d7361e570f 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -2238,7 +2238,7 @@ static void ehci_frame_timer(void *opaque)
int need_timer = 0;
int64_t expire_time, t_now;
uint64_t ns_elapsed;
- int uframes, skipped_uframes;
+ uint64_t uframes, skipped_uframes;
int i;
t_now = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL);
--
2.9.3
next prev parent reply other threads:[~2017-05-29 13:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 13:09 [Qemu-devel] [PULL 0/9] usb patch queue Gerd Hoffmann
2017-05-29 13:09 ` Gerd Hoffmann [this message]
2017-05-29 13:09 ` [Qemu-devel] [PULL 2/9] usb: Deprecate the legacy -usbdevice option Gerd Hoffmann
2017-05-29 13:09 ` [Qemu-devel] [PULL 3/9] usb: Deprecate HMP commands usb_add and usb_del Gerd Hoffmann
2017-05-29 13:09 ` [Qemu-devel] [PULL 4/9] usb: Simplify the parameter parsing of the legacy usb serial device Gerd Hoffmann
2017-05-29 13:09 ` [Qemu-devel] [PULL 5/9] xhci: split into multiple files Gerd Hoffmann
2017-05-29 13:09 ` [Qemu-devel] [PULL 6/9] xhci: add CONFIG_USB_XHCI_NEC option Gerd Hoffmann
2017-05-29 13:09 ` [Qemu-devel] [PULL 7/9] usb-hub: set PORT_STAT_C_SUSPEND on host-initiated wake-up Gerd Hoffmann
2017-05-29 13:09 ` [Qemu-devel] [PULL 8/9] usb: don't wakeup during coldplug Gerd Hoffmann
2017-05-29 13:09 ` [Qemu-devel] [PULL 9/9] ehci: fix frame timer invocation Gerd Hoffmann
2017-05-30 9:43 ` [Qemu-devel] [PULL 0/9] usb patch queue Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170529130956.20297-2-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).