From: Manos Pitsidianakis <el13635@mail.ntua.gr>
To: Alberto Garcia <berto@igalia.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel <qemu-devel@nongnu.org>, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] Throttling groups vs filter nodes
Date: Mon, 29 May 2017 23:57:37 +0300 [thread overview]
Message-ID: <20170529205737.fpbiakja36txmsnm@postretch> (raw)
In-Reply-To: <w517f0z4sb6.fsf@maestria.local.igalia.com>
On Mon, May 29, 2017 at 05:05:17PM +0200, Alberto Garcia wrote:
>On Sat 27 May 2017 09:56:03 AM CEST, Stefan Hajnoczi wrote:
>> A quirk in the current implementation is that the throttling limits
>> for the group are overwritten by each -drive throttling.group=group0.
>> Limits for all but the last -drive in a group are ignored.
> - bps or iops != 0 -> set the I/O limits of a throttling group. The
> selected device is moved to that group if it
> wasn't there yet.
>
> - bps and iops == 0 -> remove a device from a throttling group
> without touching that group's I/O limits.
These are very unintuitive. However, even without considering backwards
compatibility, I think that using -object notation (eg "object-add
throttle-group,id=foo,iops=...) is intuitive in the case of groups, but
not when you need individual limits for each device as the syntax would
be too verbose. Of course the old interface covers that.
In any case, is having multiple interfaces a problem or not? And, is
using QOM straightforward implementation-wise?
next prev parent reply other threads:[~2017-05-29 20:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-27 7:56 [Qemu-devel] Throttling groups vs filter nodes Stefan Hajnoczi
2017-05-29 15:05 ` Alberto Garcia
2017-05-29 20:57 ` Manos Pitsidianakis [this message]
2017-05-30 9:37 ` Kevin Wolf
2017-05-30 13:12 ` Alberto Garcia
2017-05-29 15:50 ` Kevin Wolf
2017-05-30 9:28 ` Stefan Hajnoczi
2017-05-30 14:29 ` Alberto Garcia
2017-05-30 15:32 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170529205737.fpbiakja36txmsnm@postretch \
--to=el13635@mail.ntua.gr \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).