qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kamil Rytarowski <n54@gmx.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, armbru@redhat.com, f4bug@amsat.org,
	marcandre.lureau@gmail.com, Kamil Rytarowski <n54@gmx.com>
Subject: [Qemu-devel] [PATCH] ivshmem-server: ivshmem-client: Build when eventfd() is available
Date: Tue, 30 May 2017 08:20:22 +0200	[thread overview]
Message-ID: <20170530062022.5841-1-n54@gmx.com> (raw)
In-Reply-To: <20170526054013.299-1-n54@gmx.com>

Currently ivshmem requires eventfd() which is Linux specific.
Do not and build it unconditionally on every Linux/BSD/Solaris.

This patch indirectly fixes build failure on NetBSD, where these tools
additionally require -lrt for shm_open(3). In future there should be
added support for NetBSD and the linking addressed appropriately.

Signed-off-by: Kamil Rytarowski <n54@gmx.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
---
 configure                            | 2 ++
 contrib/ivshmem-client/Makefile.objs | 2 +-
 contrib/ivshmem-server/Makefile.objs | 2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 1a5ee4b909..483307be53 100755
--- a/configure
+++ b/configure
@@ -4928,6 +4928,8 @@ if test "$want_tools" = "yes" ; then
   tools="qemu-img\$(EXESUF) qemu-io\$(EXESUF) $tools"
   if [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" ] ; then
     tools="qemu-nbd\$(EXESUF) $tools"
+  fi
+  if [ "$eventfd" = "yes" ]; then
     tools="ivshmem-client\$(EXESUF) ivshmem-server\$(EXESUF) $tools"
   fi
 fi
diff --git a/contrib/ivshmem-client/Makefile.objs b/contrib/ivshmem-client/Makefile.objs
index bfab2d20dd..13d864082d 100644
--- a/contrib/ivshmem-client/Makefile.objs
+++ b/contrib/ivshmem-client/Makefile.objs
@@ -1 +1 @@
-ivshmem-client-obj-y = ivshmem-client.o main.o
+ivshmem-client-obj-$(CONFIG_IVSHMEM) = ivshmem-client.o main.o
diff --git a/contrib/ivshmem-server/Makefile.objs b/contrib/ivshmem-server/Makefile.objs
index c060dd3698..d9469fd777 100644
--- a/contrib/ivshmem-server/Makefile.objs
+++ b/contrib/ivshmem-server/Makefile.objs
@@ -1 +1 @@
-ivshmem-server-obj-y = ivshmem-server.o main.o
+ivshmem-server-obj-$(CONFIG_IVSHMEM) = ivshmem-server.o main.o
-- 
2.11.1

  parent reply	other threads:[~2017-05-30  6:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-13  0:46 [Qemu-devel] [PATCH] ivshmem-server: Detect and use if there is required -lrt linking Kamil Rytarowski
2017-05-13 21:09 ` Philippe Mathieu-Daudé
2017-05-17  7:28 ` Markus Armbruster
2017-05-20 23:05   ` Kamil Rytarowski
2017-05-22  6:28     ` Markus Armbruster
2017-05-22 16:46       ` Kamil Rytarowski
2017-05-23  5:37         ` Markus Armbruster
2017-05-23 14:33           ` Kamil Rytarowski
2017-05-23 15:07             ` Markus Armbruster
2017-05-23 15:08               ` Kamil Rytarowski
2017-05-26  5:40 ` [Qemu-devel] [PATCH] ivshmem-server: ivshmem-clean: Install only when eventfd() is available Kamil Rytarowski
2017-05-26  6:31   ` Marc-André Lureau
2017-05-29  8:57     ` Markus Armbruster
2017-05-30  6:20   ` Kamil Rytarowski [this message]
2017-05-30 12:53     ` [Qemu-devel] [PATCH] ivshmem-server: ivshmem-client: Build " Eric Blake
2017-05-30 13:11       ` Kamil Rytarowski
2017-05-30 14:05         ` Eric Blake
2017-05-31 11:11           ` Markus Armbruster
2017-05-31 11:20             ` Kamil Rytarowski
2017-05-31 13:53               ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170530062022.5841-1-n54@gmx.com \
    --to=n54@gmx.com \
    --cc=armbru@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=marcandre.lureau@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).