From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33219) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFego-000430-UH for qemu-devel@nongnu.org; Tue, 30 May 2017 06:47:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFegl-0004KZ-1A for qemu-devel@nongnu.org; Tue, 30 May 2017 06:47:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34300) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dFegk-0004K2-RT for qemu-devel@nongnu.org; Tue, 30 May 2017 06:47:46 -0400 Date: Tue, 30 May 2017 18:47:41 +0800 From: Fam Zheng Message-ID: <20170530104741.GA27787@lemon.lan> References: <20170526075246.20265-1-famz@redhat.com> <20170530091939.GF11362@stefanha-x1.localdomain> <20170530093328.GC20514@lemon.lan> <0b287344-9ff8-8145-fe69-4d36f79d3557@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0b287344-9ff8-8145-fe69-4d36f79d3557@redhat.com> Subject: Re: [Qemu-devel] [PULL 00/22] Docker and block patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , stefanha@gmail.com Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, Stefan Hajnoczi On Tue, 05/30 11:36, Paolo Bonzini wrote: > > > On 30/05/2017 11:33, Fam Zheng wrote: > > On Tue, 05/30 10:19, Stefan Hajnoczi wrote: > >> On Fri, May 26, 2017 at 03:52:24PM +0800, Fam Zheng wrote: > >>> The following changes since commit 9964e96dc9999cf7f7c936ee854a795415d19b60: > >>> > >>> Merge remote-tracking branch 'jasowang/tags/net-pull-request' into staging (2017-05-23 15:01:31 +0100) > >>> > >>> are available in the git repository at: > >>> > >>> git://github.com/famz/qemu.git tags/docker-and-block-pull-request > >>> > >>> for you to fetch changes up to 77269bba94ef97de99ae61fdc98629a8704ae2ed: > >>> > >>> block: make accounting thread-safe (2017-05-26 09:25:30 +0800) > >>> > >>> ---------------------------------------------------------------- > >>> > >>> For Paolo's block layer thread safety part I and my docker testing > >>> enhancements. > >> > >> Please fix the checkpatch issues. > > > > Paolo, could you provide the comments that can be added to the memory barriers? > > It's a false positive. The comments are just a couple lines above: > > /* We have to set low before high, just like stat64_max reads > * high before low. The value may become lower temporarily, but > * stat64_get does not notice (it takes the lock) and the only ill > * effect on stat64_max is that the slow path may be triggered > * unnecessarily. > */ > atomic_set(&s->low, (uint32_t)value); > smp_wmb(); > atomic_set(&s->high, value >> 32); Ah okay, thanks! Fam